Fix for Mass upgrade dependencies #177 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this. I'll merge shortly. Regarding the ember-auto-import thing, looks like it should've been in deps anyway (see https://github.com/ef4/ember-auto-import#usage-from-addons), so that was my mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug introduced in this PR: #177
Workaround found here: webpack-contrib/css-loader#447 (comment)
Hi! o/ I'm part of the team @Gamma169 mentioned in this issue. All of the tests pass on my end with this fix and the above PR.
One additional change I made was removing
"ember-auto-import": "^1.7.0",fromdevDependenciesand updatingember-auto-importto^1.7.0independencies. I tried swapping them around (i.e. removed fromdependenciesand keptdevDependencies) but got errors. I wasn't sure how to make a PR based on an open one so I resorted to commenting here.