Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mass upgrade dependencies #177

Merged
merged 9 commits into from
Nov 24, 2020
Merged

Mass upgrade dependencies #177

merged 9 commits into from
Nov 24, 2020

Conversation

jacobq
Copy link
Member

@jacobq jacobq commented Nov 6, 2020

Things have gotten a bit dusty....
Closes #176

@jacobq
Copy link
Member Author

jacobq commented Nov 6, 2020

Looks like my TravisCI integration stuff is out of date too.... oh well, I manually started a build here and we'll see how it goes:
https://travis-ci.com/github/EmberMN/ember-cli-plotly/builds/198984321

@jacobq jacobq mentioned this pull request Nov 6, 2020
Closed
lsmun pushed a commit to lsmun/ember-cli-plotly that referenced this pull request Nov 23, 2020
Fix for Mass upgrade dependencies EmberMN#177
a12116b
@lsmun lsmun mentioned this pull request Nov 23, 2020
Merged
jacobq pushed a commit that referenced this pull request Nov 23, 2020
@jacobq
Fix for Mass upgrade dependencies #177
5b24195
@jacobq jacobq force-pushed the 2020-nov-dep-upgrade branch from 4274a45 to 88a3b3a Compare November 23, 2020 21:40
@lsmun
Copy link
Contributor

lsmun commented Nov 23, 2020

If I'm reading the logs correctly, looks like the tests are failing from lint errors. I can get to them tomorrow if you can't today.

@jacobq
Copy link
Member Author

jacobq commented Nov 23, 2020

If I'm reading the logs correctly, looks like the tests are failing from lint errors. I can get to them tomorrow if you can't today.

Yes, I'm working on them. Most are fixed with eslint --fix ., but there are a handful of others to go through. Right now I'm fixing the waiter API.

@jacobq
Copy link
Member Author

jacobq commented Nov 24, 2020

Well, the angle-brackets-codemod let me down (either that or I was doing something dumb by mistake), so I bailed on attempting to change all the {{}} components to <>, etc. but that can be done separately. We should be able to at least get another version out with updated deps here.

@jacobq jacobq merged commit 68b1954 into master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Plotly Version for 'texttemplate' and Other Features
2 participants
@jacobq @lsmun