Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)

En3Tho · Mar 5, 2021 · 0433b58 · 0433b58
1 parent 895e736
commit 0433b58
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/fsharp/NameResolution.fs b/src/fsharp/NameResolution.fs
@@ -1575,7 +1575,7 @@ let LookupTypeNameInEnvMaybeHaveArity fq nm (typeNameResInfo: TypeNameResolution
 //-------------------------------------------------------------------------
 
 /// Represents the kind of the occurrence when reporting a name in name resolution
-[<RequireQualifiedAccess; Struct>]
+[<RequireQualifiedAccess>]
 type ItemOccurence =
     /// This is a binding / declaration of the item
     | Binding

diff --git a/src/fsharp/absil/illib.fs b/src/fsharp/absil/illib.fs
@@ -494,6 +494,9 @@ module ResizeArray =
         /// in order to prevent long-term storage of those values
         chunkBySize maxArrayItemCount f inp
 
+/// Because FSharp.Compiler.Service is a library that will target FSharp.Core 4.5.2 for the forseeable future,
+/// we need to stick these functions in this module rather than using the module functions for ValueOption
+/// that come after FSharp.Core 4.5.2.
 module ValueOptionInternal =
 
     let inline ofOption x = match x with Some x -> ValueSome x | None -> ValueNone