Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TcSymbolUseData cleanup per #6084 #6089

Merged
merged 5 commits into from
Jan 17, 2019
Merged

TcSymbolUseData cleanup per #6084 #6089

merged 5 commits into from
Jan 17, 2019

Conversation

baronfel
Copy link
Member

@baronfel baronfel commented Jan 13, 2019 •
edited
Loading

This is the start of fixing #6084 according to the suggestions in that thread about chunking the ResizeArray. I need to do testing locally as well but I'll have to boot up my windows machine and get a dev environment set up so it could take a minute.

I'm mostly putting this out to verify the approach/get CI validation as I continue working to clean it up and get to a good final solution.

TODO:

  • revert whitespace changes (thanks Rider :D )
  • double-check all the index math. I tested briefly in FSI but I'm sure I missed something.

@cartermp cartermp changed the title Tcsymbolusedata cleanup per #6084 [WIP] Tcsymbolusedata cleanup per #6084 Jan 13, 2019
@baronfel baronfel force-pushed the tcsymbolusedata-cleanup branch 2 times, most recently from 031f1a8 to 5b96683 Compare January 13, 2019 18:42
dsyme
dsyme requested changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@dsyme dsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested above. You don't need to add specific tests for this

src/fsharp/NameResolution.fs Outdated Show resolved Hide resolved
dsyme
dsyme reviewed Jan 14, 2019
View reviewed changes
src/fsharp/NameResolution.fs Outdated Show resolved Hide resolved
@dsyme
Copy link
Contributor

dsyme commented Jan 14, 2019

I checked the index logic, it's fine, suggested one improvement (but check it please! :) )

@baronfel baronfel force-pushed the tcsymbolusedata-cleanup branch from 5b96683 to ed22216 Compare January 14, 2019 16:04
@baronfel
Copy link
Member Author

Ok, I made the suggested changes, including special-casing zero-length ResizeArrays.

dsyme
dsyme reviewed Jan 14, 2019
View reviewed changes
src/absil/illib.fs Outdated Show resolved Hide resolved
dsyme
dsyme reviewed Jan 14, 2019
View reviewed changes
src/absil/illib.fs Outdated Show resolved Hide resolved
@cartermp
Copy link
Contributor

cartermp commented Jan 15, 2019 •
edited
Loading

@baronfel Is this still WIP? (note: I changed the title earlier for when it still was)

@baronfel baronfel changed the title [WIP] Tcsymbolusedata cleanup per #6084 TcSymbolUseData cleanup per #6084 Jan 15, 2019
@baronfel
Copy link
Member Author

It's no longer WIP pending @dsyme accepting the changes made from his reviews.

cartermp
cartermp reviewed Jan 15, 2019
View reviewed changes
src/absil/illib.fs Outdated Show resolved Hide resolved
cartermp
cartermp approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change. Let's get a @TIHan review since he's recently also been looking at array chunking for other things

TIHan
TIHan approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and a conservative approach.

@TIHan TIHan merged commit 7584974 into dotnet:master Jan 17, 2019
@TIHan
Copy link
Contributor

TIHan commented Jan 17, 2019

Thank you.

@baronfel baronfel deleted the tcsymbolusedata-cleanup branch January 17, 2019 23:27
@cartermp cartermp mentioned this pull request Jan 18, 2019
Closed
11 tasks
@baronfel baronfel mentioned this pull request Jan 18, 2019
Closed
@auduchinok auduchinok mentioned this pull request Apr 19, 2019
Closed
auduchinok added a commit to auduchinok/fsharp that referenced this pull request May 14, 2019
@auduchinok
Revert "TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)"
8eef0dd 
This reverts commit 7584974
auduchinok added a commit to auduchinok/fsharp that referenced this pull request May 23, 2019
@auduchinok
Revert "TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)"
88436d4 
This reverts commit 7584974
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Sep 28, 2019
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
47cf5af
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Nov 22, 2019
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
66dbe21
@TIHan TIHan mentioned this pull request Dec 18, 2019
Closed
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Feb 27, 2020
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
12a3534
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Mar 3, 2020
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
8380040
DedSec256 pushed a commit to DedSec256/fsharp that referenced this pull request Apr 3, 2020
@auduchinok @DedSec256
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
ab428a6
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Apr 9, 2020
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
a4f43d3
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Apr 27, 2020
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
08bd449
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Jun 9, 2020
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
39ccbd1
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Jul 20, 2020
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
5da599d
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Jul 27, 2020
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
5f3261c
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Oct 22, 2020
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
a7b949b
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Oct 28, 2020
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
4329997
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Dec 11, 2020
@auduchinok
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
6418d79
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Mar 5, 2021
@auduchinok
Revert "TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)"
fd9382f 
This reverts commit 7584974.
En3Tho pushed a commit to En3Tho/visualfsharp that referenced this pull request Mar 5, 2021
@auduchinok @En3Tho
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
0433b58
En3Tho pushed a commit to En3Tho/visualfsharp that referenced this pull request Mar 5, 2021
@auduchinok @En3Tho
Revert TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)
2a314bd
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Apr 2, 2021
@auduchinok
Revert "TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)"
ea32cd4 
This reverts commit 7584974.
auduchinok added a commit to auduchinok/fsharp that referenced this pull request May 17, 2021
@auduchinok
Revert "TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)"
337ed77 
This reverts commit 7584974.
auduchinok added a commit to auduchinok/fsharp that referenced this pull request May 17, 2021
@auduchinok
Revert "TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)"
f40bec4 
This reverts commit 7584974.
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Jun 22, 2021
@auduchinok
Revert "TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)"
e01567f 
This reverts commit 7584974.
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Jul 12, 2021
@auduchinok
Revert "TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)"
e481dd7 
This reverts commit 7584974.
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Jul 19, 2021
@auduchinok
Revert "TcSymbolUseData cleanup per dotnet#6084 (dotnet#6089)"
c58b072 
This reverts commit 7584974.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auduchinok auduchinok auduchinok left review comments

@TIHan TIHan TIHan approved these changes

@rojepp rojepp rojepp left review comments

@dsyme dsyme dsyme approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@baronfel @dsyme @cartermp @TIHan @rojepp @auduchinok