Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCommon EventHub IAM #355

Merged
merged 26 commits into from
Oct 2, 2024
Merged

TestCommon EventHub IAM #355

merged 26 commits into from
Oct 2, 2024

Conversation

dstenroejl
Copy link
Contributor

@dstenroejl dstenroejl commented Sep 24, 2024 •
edited
Loading

Description

Part of: https://app.zenhub.com/workspaces/mosaic-60a6105157304f00119be86e/issues/gh/energinet-datahub/team-mosaic/313

Quality

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Test results for ./source/TestCommon/TestCommon.sln

  2 files    2 suites   6m 23s ⏱️
143 tests 143 ✅ 0 💤 0 ❌
145 runs  145 ✅ 0 💤 0 ❌

Results for commit 9459bce.

♻️ This comment has been updated with latest results.

@dstenroejl dstenroejl marked this pull request as ready for review October 1, 2024 19:45
HenrikSommer
HenrikSommer reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@HenrikSommer HenrikSommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few suggestions, but all-in-all it seems to be spot on

@dstenroejl dstenroejl merged commit f7ebd38 into main Oct 2, 2024
20 checks passed
@dstenroejl dstenroejl deleted the dstenroejl/event-hub-iam branch October 2, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikSommer HenrikSommer HenrikSommer approved these changes

@FirestarJes FirestarJes Awaiting requested review from FirestarJes FirestarJes is a code owner

@Sondergaard Sondergaard Awaiting requested review from Sondergaard Sondergaard is a code owner

@jonasdmoeller jonasdmoeller Awaiting requested review from jonasdmoeller jonasdmoeller is a code owner

@RasmusGraabaek RasmusGraabaek Awaiting requested review from RasmusGraabaek RasmusGraabaek is a code owner

@michaelmajgaard michaelmajgaard Awaiting requested review from michaelmajgaard michaelmajgaard is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstenroejl @HenrikSommer