Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: Use latest TestCommon #2848

Merged
merged 6 commits into from
Oct 2, 2024
Merged

refac: Use latest TestCommon #2848

merged 6 commits into from
Oct 2, 2024

Conversation

dstenroejl
Copy link
Contributor

@dstenroejl dstenroejl commented Oct 1, 2024 •
edited
Loading

Description

Latest TestCommon only support IAM (token-based authentication), and exposes Credential property on IntegrationTestConfiguration which allows us to easily reuse the same instance in multiple places.

Part of: https://app.zenhub.com/workspaces/mosaic-60a6105157304f00119be86e/issues/gh/energinet-datahub/team-mosaic/313

Pull-request quality

  • The title adheres to this guide
  • Tests are written and executed locally
  • Subsystem tests have been tested (by manually deploying to dev_002)

@dstenroejl dstenroejl mentioned this pull request Oct 1, 2024
Merged
9 tasks
@dstenroejl dstenroejl enabled auto-merge (squash) October 2, 2024 11:19
@dstenroejl dstenroejl merged commit f9b5537 into main Oct 2, 2024
45 checks passed
@dstenroejl dstenroejl deleted the dstenroejl/use-test-common branch October 2, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebbeknudsen ebbeknudsen ebbeknudsen approved these changes

@andpou andpou Awaiting requested review from andpou andpou is a code owner automatically assigned from Energinet-DataHub/team-mosaic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstenroejl @ebbeknudsen