Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[faiss v1.7.1] Add get,set verbose for Index #23

Merged
merged 3 commits into from
Jun 12, 2021

Conversation

ava57r
Copy link
Collaborator

@ava57r ava57r commented May 4, 2021

@Enet4
Copy link
Owner

Enet4 commented May 6, 2021

Thank you for your contributions to faiss-rs so far, @ava57r. Once these capabilities are given an actual release tag at the Faiss project, please let me know through these PRs, so that they may be reviewed. An eventual release of faiss-rs (0.10.0) is also soft blocked on an upcoming release, as it depends on the changes to CMake in order to build the C API.

@ava57r
Copy link
Collaborator Author

ava57r commented May 7, 2021

I finished.
You can review it

@ava57r ava57r changed the title [faiss unreleased] Add get,set verbose for Index [faiss v1.7.1] Add get,set verbose for Index May 31, 2021
@Enet4 Enet4 self-requested a review June 1, 2021 08:47
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not compile with the gpu Cargo feature, but should be easy to fix.

src/index/mod.rs Show resolved Hide resolved
@Enet4 Enet4 merged commit 76357d8 into Enet4:master Jun 12, 2021
@ava57r ava57r deleted the faiss-issue-1790 branch June 12, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants