Add get,set verbose for Index in c_api #1790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enet4
suggested changes
Mar 30, 2021
There was a problem hiding this comment.
bool exists as a built-in type in C++, but not in C (IIRC it's behind a stdbool header). I have instead used int throughout the C API, and let the compiler implicitly convert booleans back and forth.
On a side note, I was considering the use of _Bool in this API, but it was unclear whether I could integrate that in other languages such as Rust, which did not have a clear ABI definition for its boolean type bool at the time.
Co-authored-by: Eduardo Pinho <enet4mikeenet@gmail.com>
|
@mdouze has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.