[faiss v1.7.1] Impl PreTransformIndex

[ava57r]

No description provided.

[ava57r]

facebookresearch/faiss#1816

and
facebookresearch/faiss#1869

merged

[Enet4]

While most of the constructs were well thought out, this PreTransformIndexImpl can be exploited to perform memory unsafety.

• Values can outlive its native objects if they are not owned.
• ConcurrentIndex is implemented even if the native index does not.

More details and guidance in the comments below.

[ava57r]

Maybe we should not use the option when own_fields = = false?

[Enet4]

Maybe we should not use the option when own_fields = = false?

I mean, I suppose part of the problem would no longer apply if we require all indexes to be owned (and so own_fields would never be false), but adding a few type/lifetime parameters should do the trick here.

[ava57r]

I won't complicate the impl. I like the transfer of ownership.

[ava57r]

I suggest starting with the ownership of indexes, quantizers. In the future, it will become clear whether to use own_fields = = false

[Enet4]

Thank you.