-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl IndexPreTransform for c_api #1816
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ava57r
force-pushed
the
im-pre-transform-c-api
branch
from
April 12, 2021 19:52
2c13e80
to
7ccba64
Compare
ava57r
changed the title
Improve IndexPreTransform support for c_api
[WIP] Improve IndexPreTransform support for c_api
Apr 13, 2021
ava57r
changed the title
[WIP] Improve IndexPreTransform support for c_api
[WIP] Impl IndexPreTransform for c_api
Apr 13, 2021
ava57r
force-pushed
the
im-pre-transform-c-api
branch
from
April 13, 2021 09:18
f518df7
to
7e5baea
Compare
ava57r
force-pushed
the
im-pre-transform-c-api
branch
from
April 14, 2021 08:58
21921fb
to
330171d
Compare
ava57r
changed the title
[WIP] Impl IndexPreTransform for c_api
Impl IndexPreTransform for c_api
Apr 14, 2021
more indexes with an |
Enet4
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to go.
The matter of immutable reference guarantee may be handled at faiss-rs
.
@mdouze has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends c_api for IndexPreTransform