Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_end VCF parser - ENSINT-2005 for main #172

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

sgiorgetti
Copy link
Contributor

This PR is sister to #171
Please, see the above one for details.

Changes

  • patched get_end (not for SV)
  • fixed test suite and re-arranged test data
    Co-authored-by: Syed Nakib Hossain snhossain@ebi.ac.uk

- patched get_end (not for SV)
- fixed test suite and re-arranged test data
Co-authored-by: Syed Nakib Hossain <snhossain@ebi.ac.uk>
Copy link
Member

@TamaraNaboulsi TamaraNaboulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changes as #171 but for the main branch. Change was tested and approved by Likhitha. Looks good to me.

@sgiorgetti sgiorgetti merged commit 4790daf into main Nov 15, 2024
2 checks passed
@sgiorgetti sgiorgetti deleted the fix/vcf_parser-main branch November 15, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants