Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rails 4.2 #1

Merged
merged 2 commits into from
May 1, 2018
Merged

Support Rails 4.2 #1

merged 2 commits into from
May 1, 2018

Conversation

arjun810
Copy link
Contributor

It seems like it all works with Rails 4.2.

@Envek Envek merged commit f22d1c1 into Envek:master May 1, 2018
Envek added a commit that referenced this pull request May 1, 2018
Merges #1

Merge branch 'ar-4-2-support'

* ar-4-2-support:
  On AR 4.2 raise exception on before_commit call as it's not implemented
  Test with ActiveRecord 4.2
  Support Rails 4.2
@Envek
Copy link
Owner

Envek commented May 1, 2018

Thank you very much!

Actually, before_commit is not available on 4.2, so I've just disabled it and then merged.

While before_commit can be backported using refinements I think it is too rarely used functionality so it can be ignored for old Rails versions.

@Envek
Copy link
Owner

Envek commented May 1, 2018

Released 0.1.2

@arjun810
Copy link
Contributor Author

arjun810 commented May 2, 2018

awesome, thanks!

andrebarretofv added a commit to andrebarretofv/after_commit_everywhere that referenced this pull request Jul 10, 2024
Merges Envek/after_commit_everywhere#1

Merge branch 'ar-4-2-support'

* ar-4-2-support:
  On AR 4.2 raise exception on before_commit call as it's not implemented
  Test with ActiveRecord 4.2
  Support Rails 4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants