Enable ActiveRecord 4.2 support.

Merges Envek/after_commit_everywhere#1

Merge branch 'ar-4-2-support'

* ar-4-2-support:
  On AR 4.2 raise exception on before_commit call as it's not implemented
  Test with ActiveRecord 4.2
  Support Rails 4.2

.travis.yml

@@ -11,6 +11,8 @@ addons:
 
 matrix:
   include:
+    - rvm: 2.5.1
+      gemfile: gemfiles/activerecord_4_2.gemfile
     - rvm: 2.5.1
       gemfile: gemfiles/activerecord_5_0.gemfile
     - rvm: 2.5.1

Appraisals

@@ -1,4 +1,8 @@
 # frozen_string_literal: true
+#
+appraise 'activerecord-4-2' do
+  gem 'activerecord', '~> 4.2.0'
+end
 
 appraise 'activerecord-5-0' do
   gem 'activerecord', '~> 5.0.0'

README.md

@@ -98,6 +98,8 @@ Will be executed right before outermost transaction will be commited _(I can't i
 
 If called outside transaction will execute callback immediately.
 
+Supported only starting from ActiveRecord 5.0.
+
 #### `after_rollback`
 
 Will be executed right after transaction in which it have been declared was rolled back (this might be nested savepoint transaction block with `requires_new: true`).

after_commit_everywhere.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'activerecord', '>= 5.0'
+  spec.add_dependency 'activerecord', '>= 4.2'
   spec.add_development_dependency 'appraisal'
   spec.add_development_dependency 'bundler', '~> 1.16'
   spec.add_development_dependency 'pry'

gemfiles/activerecord_4_2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", "~> 4.2.0"
+
+gemspec path: "../"

lib/after_commit_everywhere.rb

@@ -33,10 +33,15 @@ def after_commit(connection: ActiveRecord::Base.connection, &callback)
   #
   # If called outside transaction it will execute callback immediately.
   #
+  # Available only since Ruby on Rails 5.0. See https://github.com/rails/rails/pull/18936
+  #
   # @param connection [ActiveRecord::ConnectionAdapters::AbstractAdapter]
   # @param callback   [#call] Callback to be executed
   # @return           void
   def before_commit(connection: ActiveRecord::Base.connection, &callback)
+    if ActiveRecord::VERSION::MAJOR < 5
+      raise NotImplementedError, "#{__callee__} works only with Rails 5.0+"
+    end
     AfterCommitEverywhere.register_callback(
       connection: connection,
       name: __callee__,

lib/after_commit_everywhere/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AfterCommitEverywhere
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

spec/after_commit_everywhere_spec.rb

@@ -122,6 +122,16 @@
       end
     end
 
+    if ActiveRecord::VERSION::MAJOR < 5
+      it 'fails because it is unsupported in Rails 4' do
+        expect { subject }.to raise_error(NotImplementedError) do |ex|
+          expect(ex.message).to match(/Rails 5\.0\+/)
+        end
+      end
+
+      next
+    end
+
     context 'within transaction' do
       it 'executes code only before commit' do
         ActiveRecord::Base.transaction do