Add support for skipInitialPoll parameter (FF-2084) #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
approved these changes
May 16, 2024
src/index.spec.ts
Outdated
| @@ -507,6 +507,28 @@ describe('initialization options', () => { | |||
| expect(client.getStringAssignment(flagKey, 'subject', {}, 'default-value')).toBe('control'); | |||
| }); | |||
|
|
|||
| it('skips initial poll', async () => { | |||
| assignmentLogger: mockLogger, | ||
| skipInitialPoll: true, | ||
| }); | ||
| expect(callCount).toBe(0); |
src/index.ts
Outdated
| /** | ||
| * Skip the first poll for new configurations during initialization. (default: false) | ||
| */ | ||
| skipInitialPoll?: boolean; |
There was a problem hiding this comment.
Just a thought: "poll" implies a request made repeatedly at intervals. skipInitialRequest?
There was a problem hiding this comment.
Good idea - I was being too pedantic with the mechanics of the internal poller. For customers they are not going to know that and the naming you suggested is more clear 👍 👍
src/index.ts
Outdated
| @@ -160,6 +165,7 @@ export async function init(config: IClientConfig): Promise<IEppoClient> { | |||
| pollAfterSuccessfulInitialization: config.pollAfterSuccessfulInitialization ?? false, | |||
| pollAfterFailedInitialization: config.pollAfterFailedInitialization ?? false, | |||
| throwOnFailedInitialization: true, // always use true here as underlying instance fetch is surrounded by try/catch | |||
| skipInitialPoll: config.skipInitialPoll ?? false, | |||
ploomiz
approved these changes
May 16, 2024
sameerank
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
Customers can elect to put the client SDK into "offline" mode - one of the configurations they need to enable is preventing the SDK from performing a CDN fetch during the
initmethod.Subsequent calls to the CDN will be blocked by setting the
isExpiredfunction in the persistence store implementations.Description
skipInitialPollHow has this been tested?