Provide a customer persistence store (FF-2085) #65
Conversation
| export function configurationStorageFactory(): IConfigurationStore<Flag> { | ||
| if (hasWindowLocalStorage()) { | ||
| export function configurationStorageFactory( | ||
| persistenceStore?: IAsyncStore<Flag>, |
There was a problem hiding this comment.
Consider renaming to persistentStore, which I think is what this is usually called, unless I'm misunderstanding what this is
There was a problem hiding this comment.
And I think it makes sense as an argument in init rather than a usePersistentStore(store) method that could modify the client's storage after it has been initialized. If there's a scenario where swapping stores is useful, it doesn't seem like we're blocked from providing that method in the future.
There was a problem hiding this comment.
And I think it makes sense as an argument in init rather than a usePersistentStore(store) method that could modify the client's storage after it has been initialized
That was my thinking too - can't imagine wanting to swap this out in the middle of a session.
labels: mergeable
Fixes: #issue
Motivation and Context
Allow customers to provide a customer persistence store implementation of
IAsyncStore. They can pair this with (#64) to create an "off-line" mode where the client CDN will not make any remote requests. In this case they would provide aIAsyncStorethat reads from a local file (or memory) for a configuration that was provided by their server.Another use case is for AWS Lambda functions, not in scope for this PR as that is nodejs, which are very short-lived servers. Their persistence store can be backed by DynamoDB to avoid many CDN requests.
Description
persistenceStore- if provided aHybridConfigurationStorewill be created with itquestions for reviewers
In order to provide the persistence store, I needed to instantiate the Client singleton within the
initmethod. Does this seem like an acceptable compromise? The alternative is adding ausePersistenceStore()method onto js-commons.How has this been tested?