FF-2501 Include config fetch/publish time with assignment details #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghuels
changed the base branch from
greg/FF-2465/evaluation-reasons
to
greg/FF-2465/evaluation-reasons-4
greghuels
changed the title
greghuels
commented
Jun 24, 2024
| @@ -209,12 +212,15 @@ export default class EppoClient { | |||
| * @param defaultValue default value to return if the subject is not part of the experiment sample | |||
| * @returns a boolean variation value if the subject is part of the experiment sample, otherwise the default value | |||
| */ | |||
| public getBooleanAssignment = ( | |||
| public getBooleanAssignment( | |||
There was a problem hiding this comment.
arrow functions caused a few TypeScript errors in EppoJSClient, so I reverted back to class methods
greghuels
commented
Jun 24, 2024
| @@ -26,7 +26,11 @@ export interface IConfigurationStore<T> { | |||
| getKeys(): string[]; | |||
| isInitialized(): boolean; | |||
| isExpired(): Promise<boolean>; | |||
| setEntries(entries: Record<string, T>): Promise<void>; | |||
| setEntries(entries: Record<string, T>): Promise<boolean>; | |||
There was a problem hiding this comment.
setEntries now returns Promise<boolean>. If you resolve with true, it tells js-client-sdk-common to update the configFetchTime and configPublishTime
greghuels
commented
Jun 24, 2024
src/flag-configuration-requestor.ts
Outdated
Comment on lines
19
to
20
| this.configurationStore.setConfigFetchTime(new Date().toISOString()); | ||
| this.configurationStore.setConfigPublishTime(responseData.createdAt); |
There was a problem hiding this comment.
only set the config fetch/publish time if the serving store was updated
Base automatically changed from
greg/FF-2465/evaluation-reasons-4
to
greg/FF-2465/evaluation-reasons
June 24, 2024 20:03
greghuels
force-pushed
the
greg/FF-2501/evaluation-reasons-config-time
branch
from
0c86c0f to
554ceca
Compare
sameerank
approved these changes
Jun 24, 2024
src/client/eppo-client.ts
Outdated
Comment on lines
500
to
501
| configFetchTime, | ||
| configPublishTime, |
There was a problem hiding this comment.
Just wondering -- is it obvious that "time" implies date-time? Thoughts on renaming these?
Suggested change
| configFetchTime, | |
| configPublishTime, | |
| configFetchedAt, | |
| configPublishedAt, |
There was a problem hiding this comment.
I can do that. I'll update.
greghuels
added a commit
that referenced
this pull request
Jul 2, 2024
* FF-2501 Include config fetch/publish time with assignment details * FF-2501 do not use arrow functions for functionality that's extended * FF-2501 configFetchTime/configPublishTime --> configFetchedAt/configPublishedAt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF-2501
js-client-sdk implements this functionality in Eppo-exp/js-client-sdk#90
Motivation and Context
Implements
configFetchTimeandconfigPublishTimeto give users a better understanding of which version of the configuration is loaded.How has this been tested?
Integration testing