[cli] Do not print sensitive information when exception happens #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that the `performLogin` API functions throws an exception. On the client side we print the API function name and the argument list if an exception happens. The argument list may contain sensitive information such as password. In this patch we will skip printing the argument list in this situation.
csordasmarton
added
CLI 💻
bruntib
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the
performLoginAPI functions throws an exception.On the client side we print the API function name and the argument list
if an exception happens. The argument list may contain sensitive
information such as password. In this patch we will skip printing
the argument list in this situation.