Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Do not print sensitive information when exception happens #3355

Merged
merged 1 commit into from
Jun 18, 2021
Merged

[cli] Do not print sensitive information when exception happens #3355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions web/client/codechecker_client/thrift_call.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,14 @@ def wrapper(self, *args, **kwargs):
LOG.error('Thrift bad version error.')
LOG.error(funcName)

# It is possible that one of the argument is too large to log the
# full content of it (for example the 'b64zip' parameter of the
# Do not print the argument list if it contains sensitive
# information such as passwords.
# Also it is possible that one of the argument is too large to log
# the full content of it (for example the 'b64zip' parameter of the
# 'massStoreRun' API function). For this reason we have to truncate
# the arguments.
LOG.error([truncate_arg(arg) for arg in args])
if funcName != "performLogin":
LOG.error([truncate_arg(arg) for arg in args])

LOG.error(kwargs)
LOG.exception("Request failed.")
Expand Down