Add severity to CodeClimate export #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
suggested changes
Jun 11, 2021
| @@ -638,7 +638,7 @@ def parse_convert_reports(input_dirs: List[str], | |||
|
|
|||
| number_of_reports = len(all_reports) | |||
| if out_format == "codeclimate": | |||
| return codeclimate.convert(all_reports), number_of_reports | |||
| return codeclimate.convert(all_reports, severity_map), number_of_reports | |||
There was a problem hiding this comment.
Pylint complains that this line is too long:
codechecker_analyzer/cmd/parse.py:641:80: E501 line too long (80 > 79 characters)
make[1]: *** [pycodestyle] Error 1
Could you please fix this problem?
Comment on lines
29
to
33
| 'UNDEFINED': 'info', | ||
| 'LOW': 'minor', | ||
| 'STYLE': 'minor', | ||
| 'MEDIUM': 'high', | ||
| 'HIGH': 'critical', |
There was a problem hiding this comment.
We have the following severity levels:
- Critical
- High
- Medium
- Low
- Style
- Unspecified
So I recommend to change this map to this one:
Suggested change
| 'UNDEFINED': 'info', | |
| 'LOW': 'minor', | |
| 'STYLE': 'minor', | |
| 'MEDIUM': 'high', | |
| 'HIGH': 'critical', | |
| 'CRITICAL': 'critical', | |
| 'HIGH': 'major', | |
| 'MEDIUM': 'minor', | |
| 'LOW': 'minor', | |
| 'STYLE': 'info', | |
| 'UNSPECIFIED': 'info' |
What do you think?
There was a problem hiding this comment.
Sure, thanks. I have no idea where I got the high from.
| """Convert a Report to Code Climate format.""" | ||
| return { | ||
| "type": "issue", | ||
| "check_name": report.check_name, | ||
| "description": report.description, | ||
| "categories": ["Bug Risk"], | ||
| "fingerprint": report.report_hash, | ||
| "severity": __codeclimate_severity_map.get( |
There was a problem hiding this comment.
Some test cases are failed.
- https://github.com/Ericsson/codechecker/blob/master/analyzer/tests/functional/analyze_and_parse/test_analyze_and_parse.py#L310 - Missing severity level.
- Traceback (most recent call last):
File "/home/runner/work/codechecker/codechecker/web/tests/functional/diff_local_remote/test_diff_local_remote.py", line 465, in test_diff_codeclimate_output
self.assertTrue(os.path.exists(codeclimate_issues_file))
Could you please fix these test cases?
There was a problem hiding this comment.
fixed, though I couldn't run test_functional all the way. I don't have db set up for it.
| @@ -638,7 +638,7 @@ def parse_convert_reports(input_dirs: List[str], | |||
|
|
|||
| number_of_reports = len(all_reports) | |||
| if out_format == "codeclimate": | |||
| return codeclimate.convert(all_reports), number_of_reports | |||
| return codeclimate.convert(all_reports, severity_map), number_of_reports | |||
There was a problem hiding this comment.
Please update the convert function here with the serverity map:
jmalmari
force-pushed
the
codeclimate-severity
branch
from
ca9f933 to
45dfd69
Compare
csordasmarton
added
analyzer 📈
csordasmarton
approved these changes
Jun 18, 2021
bachp
pushed a commit
to bachp/meta-codechecker
that referenced
this pull request
Aug 11, 2021
The severity field is needed by Gitlab-CI to process codeclimate report. This commit patch the current version of codechecker with the change introduced upstream with this pull request: Ericsson/codechecker#3356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #3342 (comment)