[clang-tidy][cfg] Remove an alias from the extreme profile #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steakhal
force-pushed
the
fix-check-alias
branch
from
e94e327 to
06e3b3c
Compare
It seems like that `bugprone-narrowing-conversions` check is the same as the `cppcoreguidelines-narrowing-conversions` check. Check this: https://github.com/llvm/llvm-project/blob/c63522e6ba7782c335043893ae7cbd37eca24fe5/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp#L136-L137 It seems like both of these checks were included in the `extreme` profile, thus each of these reports were duplicated basically. Hereby I'm proposing to keep only one of them in the profile to workaround this issue. According to Compiler Explorer https://godbolt.org/z/hvMnqrfEx, clang-tidy reports these issues only once, with the `[check,alias,alias...]` schema, thus it does the right thing. However, PR Ericsson#3238 introduced a logic that splits these reports into individual reports. I'm not sure if that is the right way of dealing with check aliases, but we definitely need something more robust than including/excluding checks from profiles.
steakhal
force-pushed
the
fix-check-alias
branch
from
06e3b3c to
0bd7dd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like that
bugprone-narrowing-conversionscheck is the same asthe
cppcoreguidelines-narrowing-conversionscheck.Check this:
https://github.com/llvm/llvm-project/blob/c63522e6ba7782c335043893ae7cbd37eca24fe5/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp#L136-L137
It seems like both of these checks were included in the
extremeprofile, thus each of these reports were duplicated basically.
Hereby I'm proposing to keep only one of them in the profile to
workaround this issue.
According to Compiler Explorer, clang-tidy reports these issues only
once, with the
[check,alias,alias...]schema, thus it does the rightthing. However, PR #3238 introduced a logic that splits these reports
into individual reports.
I'm not sure if that is the right way of dealing with check aliases, but
we definitely need something more robust than including/excluding checks
from profiles.