[fix] Minor fixing for statistics tabs #4304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cservakt
force-pushed
the
minor-statistics-fixing
branch
from
4d32b4a to
24b23ff
Compare
The `compare to` filter was turned off for statistics tabs. It is a user request to restore it. Every tabs gets back the filter except checker coverage. Switching between tabs was problematic. When we want to switch from checker coverage to others tab, it triggers a full page refresh. Now, it is fixed. The status of the checkere coverage does not show the number of disabled runs for checkers. With this PR, the user can be informed about the number of runs the checker is off and they can also open the disabled runs modal to list them.
cservakt
force-pushed
the
minor-statistics-fixing
branch
from
24b23ff to
131e254
Compare
bruntib
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compare tofilter was turned off for statistics tabs. It is a user request to restore it. Every tabs gets back the filter except checker coverage.Switching between tabs was problematic. When we want to switch from checker coverage to others tab, it triggers a full page refresh. Now, it is fixed.
The status of the checkere coverage does not show the number of disabled runs for checkers. With this PR, the users can be informed about the number of runs the checker is off and they can also open the disabled runs modal to list them.