Light client test merge #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new trait encapsulates * Data source creation from command line options * Looking up timestamp windows It is currently implemented for FileSystemDataSource, but having this trait will make it easy to incoporate the new SqlDataSource: just implement the same trait.
api.rs has been very hard to work with, because almost all of the logic, from initialization to endpoint handling, was in a single massive, deeply nested function. Now there are smaller, less nested modules separately handling initialization, endpoints, and state updates. This should make it much easier to read, modify, and extend the code.
Modularize API storage
* add from_bytes, rename build -> from_txs * add test infra for bad blocks * add tx table proofs * check tx table proofs in basic_correctness test * tidy * support zero-length txs * flag new TODOs with TODO(795) * tweak comments * address https://github.com/EspressoSystems/espresso-sequencer/pull/796/files#r1414786947 * cache tx table len proof (whew) * add TxInclusionProof::verify() as per #796 (comment) * TxInclusionProof::tx_table_range_proof should always be a SINGLE RangeProof * as per #796 (comment) add tx_table_len, tx_table_range_[start|end] to TxInclusionProof, remove 4 args from TxInclusionProof::verify() * tidy
…ons (#791) --------- Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com>
Nothing is building yet but the basic structure of the header and payload should be evident
…e up. (#883) Ensure the anvil endpoints are up in `AnvilOptions::spawn`.
…that we can increase if we succeed Signed-off-by: nomaxg <noahgolub2@gmail.com>
Signed-off-by: nomaxg <noahgolub2@gmail.com>
Reduce max_blocks in the commit task if we exceed the block gas limit
Add a tool to reset persistent storage
…update Update/tide disco cargo update
* add test for correctness of block.iter() * add test for expected number of txs in a block * refactor test * tidy test * add failing test case, more test tidying * test pass but watch out for overflow * add test with huge tx table len * accommodate extremely small payloads * test infra allow larger payload, not just truncated payload * begin refactoring test code * tidy test * tidy tests * add TODO(817) comments * add test for malicious tx inclusion proof * NamespaceTable stub * WIP: add namespace table to payload, need to update tests * fix test * WIP rework basic_correctness test for multiple namespaces * WIP fixing bugs * WIP begin tidying tests * tidy tests * tidy * be less stupid as per #891 (comment)
This reverts commit 3cf2ab2.
Contract tests are still failing
Failing tests:
Encountered 4 failing tests in contracts/test/BLSSig.t.sol:BLSSig_Test
[FAIL. Reason: EvmError: Revert; counterexample: calldata=0xe1dc7d9400000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000000 args=[0x]] testFuzz_BLS_hashes_computation(bytes) (runs: 0, μ: 0, ~: 0)
[FAIL. Reason: EvmError: Revert] test_RevertWhen_SignatureIsInvalid() (gas: 6949)
[FAIL. Reason: EvmError: Revert] test_RevertWhen_usingWrongVK() (gas: 6860)
[FAIL. Reason: EvmError: Revert] test_SigVerification_Succeeds() (gas: 6795)
Encountered 1 failing test in contracts/test/StakeTable.t.sol:StakeTable_Test
[FAIL. Reason: setup failed: custom error a1ba07ee:] setUp() (gas:
0)
On issue is that the LightClientState constructor does not allow zero
commitments anymore. The test setUp function calls the constructor with
zeroes.
Not sure why the BLS tests are failing.
sveitser
requested review from
nomaxg,
philippecamacho,
ImJeremyHe and
jbearer
as code owners
|
|
Yes as written on the other PR and in the commit message there are some failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.