Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: append G2 point from SRS to transcript #647

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Aug 3, 2024

Part of: EspressoSystems/espresso-sequencer#1731

This PR:

  • add G2 point from KZG SRS to the plonk transcript to restrict the undesirable degree of freedom

This PR is targeting a temp branch commonprefix-patch and would eventually be merged to main with a new tag.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added relevant changelog entries to the CHANGELOG.md of touched crates.
  • Re-reviewed Files changed in the GitHub PR explorer

Copy link
Contributor

@philippecamacho philippecamacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question, otherwise LGTM.

@alxiong alxiong merged commit e30e675 into commonprefix-patch Aug 5, 2024
5 checks passed
@alxiong alxiong deleted the cp-m04 branch August 5, 2024 14:40
alxiong added a commit that referenced this pull request Sep 4, 2024
* feat: append G2 point from SRS to transcript (#647)

* append G2 point from SRS to transcript

* use powers_of_h[1] instead of beta_h

* refactor!: refactored transcript traits and impls (#648)

* refactor transcript trait and impl

* align transcript with 32byte word size

* address comments

* update changelog and jf-plonk version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants