refactor!: refactored transcript traits and impls #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxiong
force-pushed
the
refactor-transcript
branch
from
b927d37
to
a2bd44a
Compare
alxiong
force-pushed
the
refactor-transcript
branch
from
a4a9f82
to
392555a
Compare
alxiong
force-pushed
the
refactor-transcript
branch
from
392555a
to
4b53961
Compare
philippecamacho
approved these changes
Aug 7, 2024
|
All of your comments are addressed in 2956aa5 I'll update the CHANGELOG when we merge all changes into |
alxiong
added a commit
that referenced
this pull request
Sep 4, 2024
* feat: append G2 point from SRS to transcript (#647) * append G2 point from SRS to transcript * use powers_of_h[1] instead of beta_h * refactor!: refactored transcript traits and impls (#648) * refactor transcript trait and impl * align transcript with 32byte word size * address comments * update changelog and jf-plonk version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed in https://www.notion.so/espressosys/Fiat-Shamir-Transcript-f29ccc7a23c94178aac5cfa5d336fd63 and discussed on Zulip, we decide to remove
get_and_append_challenge()and only useget_challenge()and also introduce backstatefor solidity transcript as most other projects do.This partially undone some changes made in #619.
This PR:
trait Transcriptget_and_append_challenge()toget_challenge()get_n_challenges()for multiple challenges for the same roundsappend_challenge()toappend_field()append_fields()struct SolidityTranscript: adding backstateand squeeze logic (see code comment)Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Targeted PR against correct branch (main)Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.Wrote unit testsCHANGELOG.mdof touched crates.Files changedin the GitHub PR explorer