Handle decreasing l1 block number #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this removes a call to GetBlockByNumber, where the resulting block was used only to get the block number! This should reduce Infura usage by one call per zkevm node per HotShot block.
This allows us to use the L1 head from HotShot as the L1 block number when reading batches from NewBlocks events in regular mode, without messing up the rest of the synchronizer which assumes the L1 block number is the current L1 block we're synchronizing. This brings the regular node into consistency with the preconfirmations node.
This should make the node more robust if this case ever does happen. It shouldn't happen, and if it does we'll need to debug and fix it. But at least we have a chance that the node will keep running.
nomaxg
reviewed
Oct 6, 2023
| } | ||
| log.Infof("L1 block %d does not already exist, adding to database", blockNumber) | ||
| err = s.state.AddBlock(s.ctx, &b, dbTx) | ||
| if err != nil { |
There was a problem hiding this comment.
What is the behavior if the contract event handler is concurrently calling AddBlock? Is that a race condition we need to address here? If the contract handler adds the block between lines 619 and here and 645 errors out, we wouldn't need to bubble up an error.
There was a problem hiding this comment.
This should not be possible because we hold a lock on the DB here (everything done with dbTx should be atomic).
Also, AddBlock is idempotent, so even if this race did happen, 645 should succeed and everything should be ok.
nomaxg
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.