Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle decreasing l1 block number #84

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Handle decreasing l1 block number #84

merged 4 commits into from
Oct 6, 2023

Commits on Oct 6, 2023

  1. Handle decreasing L1 block number

    @jbearer
    jbearer committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    55c8421 View commit details
    Browse the repository at this point in the history

  2. Clean up computation of L2BatchInfo and SequencedBatch in etherman 

    In particular, this removes a call to GetBlockByNumber, where the
resulting block was used only to get the block number! This should
reduce Infura usage by one call per zkevm node per HotShot block.
    @jbearer
    jbearer committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5dac440 View commit details
    Browse the repository at this point in the history

  3. Decouple batch L1 origin from L1 block where batch was received 

    This allows us to use the L1 head from HotShot as the L1 block
number when reading batches from NewBlocks events in regular mode,
without messing up the rest of the synchronizer which assumes the
L1 block number is the current L1 block we're synchronizing. This
brings the regular node into consistency with the preconfirmations
node.
    @jbearer
    jbearer committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    78c0718 View commit details
    Browse the repository at this point in the history

  4. Replace fatal error with either skipping or retrying batch 

    This should make the node more robust if this case ever does
happen. It shouldn't happen, and if it does we'll need to debug
and fix it. But at least we have a chance that the node will keep
running.
    @jbearer
    jbearer committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    8b53652 View commit details
    Browse the repository at this point in the history