Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completeOAuth2 checks window.parent and window.opener for handler #712

Closed
wants to merge 3 commits into from
Closed

completeOAuth2 checks window.parent and window.opener for handler #712

wants to merge 3 commits into from

Conversation

pfcstyle
Copy link
Contributor

@pfcstyle pfcstyle commented Jun 28, 2020

See #711

# Conflicts:
#	packages/arcgis-rest-auth/src/UserSession.ts
@pfcstyle pfcstyle changed the title Issue#508 For issue #711 Jun 28, 2020
@pfcstyle
Copy link
Contributor Author

#711

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@abaaa16). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master      #712   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?       107           
  Lines             ?      1635           
  Branches          ?       293           
==========================================
  Hits              ?      1635           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
...s/arcgis-rest-portal/test/mocks/items/resources.ts 100.00% <0.00%> (ø)
...kages/arcgis-rest-portal/src/users/get-user-url.ts 100.00% <0.00%> (ø)
...rcgis-rest-request/test/mocks/sharing-rest-info.ts 100.00% <0.00%> (ø)
...cgis-rest-portal/src/util/get-subscription-info.ts 100.00% <0.00%> (ø)
packages/arcgis-rest-portal/src/users/update.ts 100.00% <0.00%> (ø)
packages/arcgis-rest-request/test/mocks/webmap.ts 100.00% <0.00%> (ø)
...arcgis-rest-portal/test/mocks/users/user-search.ts 100.00% <0.00%> (ø)
packages/arcgis-rest-geocoding/src/suggest.ts 100.00% <0.00%> (ø)
...ackages/arcgis-rest-portal/src/users/invitation.ts 100.00% <0.00%> (ø)
packages/arcgis-rest-auth/test/utils.ts 100.00% <0.00%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abaaa16...d794e0b. Read the comment docs.

@dbouwman dbouwman changed the title For issue #711 completeOAuth2 checks window.parent and window.opener for handler Jul 1, 2020
@dbouwman dbouwman marked this pull request as draft July 1, 2020 13:39
@dbouwman
Copy link
Member

dbouwman commented Jul 1, 2020

@pfcstyle - does not look like any actual changes were pushed up on your branch.

@dbouwman
Copy link
Member

dbouwman commented Jul 1, 2020

Closing in favor of #714

@dbouwman dbouwman closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants