-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(arcgis-rest-auth): enable oAuth from within an IFrame #714
Conversation
Adds a new check for oauth handler on window.opener, and cleans up previous handler checks. AFFECTS PACKAGES: @esri/arcgis-rest-auth ISSUES CLOSED: #711
I'm going to verify this by |
Verified this works in scenarios where the caller is in an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work @dbouwman!
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 107
Lines ? 1635
Branches ? 293
==========================================
Hits ? 1635
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
Adds a new check for oauth handler on window.opener, and cleans up previous handler checks.
AFFECTS PACKAGES:
@esri/arcgis-rest-auth
ISSUES CLOSED: #711