Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tree] Add hover states #6930

Open
Tracked by #7733
geospatialem opened this issue May 6, 2023 · 4 comments
Open
Tracked by #7733

[Tree] Add hover states #6930

geospatialem opened this issue May 6, 2023 · 4 comments
Labels
0 - new New issues that need assignment. c-tree Issues that pertain to the calcite-tree and related components Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library

Comments

@geospatialem
Copy link
Member

Description

Add hover states to the tree component.

Provides a distinct hover state between:

  • Selecting & expanded a parent item,
  • Just expanding a parent, and
  • Just the triggering the item's action.

The background also consistently extends to the left when hovering over the icon and text container, whether it is a parent item with decedents, item without decedents, or child item.

cc: #6912, #6926

image

Acceptance Criteria

Pertains to the criteria defined by @SkyeSeitz in #6912 (comment):

Link to prototype with different hover state options. I am favoring the second in this list labeled "Background hovers without action" as it provides distinct hover states between: selecting & expanded a parent item, just expanding, and just the triggering the action. The background also consistently extends to the left when hovering over the icon + text container, whether it is a parent item with decedents, item without decedents, or child item.

Screen.Recording.2023-05-04.at.3.37.40.PM.mov

Relevant Info

Remaining from tree enhancement work in #6926 (comment) for Online R02 to add hover states to the tree compnent.

Which Component

tree

Example Use Case

No response

Priority impact

p3 - want for upcoming milestone

Esri team

Calcite (design)

@geospatialem geospatialem added enhancement Issues tied to a new feature or request. p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 5 A few days of work, definitely requires updates to tests. c-tree Issues that pertain to the calcite-tree and related components ready for dev Issues ready for development implementation. labels May 6, 2023
@geospatialem geospatialem added this to the 2023 August Priorities milestone May 6, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone Calcite (design) Issues logged by Calcite designers. labels May 6, 2023
@SkyeSeitz
Copy link

Link to prototype of finalized hover behavior.

@ashetland
Copy link

Link to prototype of finalized hover behavior.

Updates to these designs may occur as a result from design efforts in epic #7181 related to this comment in issue #6700.

@geospatialem geospatialem added design Issues that need design consultation prior to development. and removed ready for dev Issues ready for development implementation. labels Aug 30, 2023
@geospatialem
Copy link
Member Author

Added to the current design sprint for a final pass before implementation.

@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@ashetland ashetland modified the milestones: Design Now, Design Backlog Sep 13, 2023
@ashetland
Copy link

Added to epic #7733 for system-wide considerations.

@ashetland ashetland removed their assignment Sep 13, 2023
@ashetland ashetland removed the 1 - assigned Issues that are assigned to a sprint and a team member. label Sep 13, 2023
@ashetland ashetland added 0 - new New issues that need assignment. p - low Issue is non core or affecting less that 10% of people using the library and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Sep 13, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. c-tree Issues that pertain to the calcite-tree and related components Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

5 participants