-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calcite tree - allow selection of parent category w/out selecting children #6912
Comments
@SkyeSeitz @ashetland Could you take a peek at this one? The solution will likely be a new prop on |
Possible related issue: #6509, which is a bug request on |
Some thinky thoughts and notes on interaction behavior so we can align and discuss any open ended questions :) |
@SkyeSeitz that design covers our workflow really well. This is a change to how the children mode operates, but I think it's a good change and much more intuitive. |
Agreed. Nice work Skye. Do we think we can clean up hover states on this as well to make things more clear or does that need to wait to get this implemented faster? |
I can add hover changes as part of this pr if the designs are done in the very near future |
Thank you, @paulcpederson! Hover states are ready for review here. |
Link to prototype with different hover state options. I am favoring the second in this list labeled "Background hovers without action" as it provides distinct hover states between: selecting & expanded a parent item, just expanding, and just the triggering the action. The background also consistently extends to the left when hovering over the icon + text container, whether it is a parent item with decedents, item without decedents, or child item. Screen.Recording.2023-05-04.at.3.37.40.PM.mov |
#6926) **Related Issue:** #6912, #6444, #6509 ## Summary Updates the interaction model of trees to adhere to the [new design](https://www.figma.com/file/R0B6ljDBIyKPtEa5GXjSjx/Tree-%5Bparent%2Fchildren-selection%5D-%5B6912%5D?node-id=1-76826&t=GOElQQiBF6PkKrgN-0). The key changes to the interaction model are: 1. Tree items will expand when they are clicked (#6444) 2. Child selection modes will not automatically display all children of a selected item as selected (#6912) 3. Clicking a slotted action inside a tree item will not select the tree item (#6509) Note: this pr does not address the hover states in that design. We are coming down to the wire and I want to give time for code review. I can help address the styling/focus/hover/accessibility aspects of the tree next release.
Verified in Note: To ensure the PR made the upcoming release the hover states above were not part of the effort, but will be added to a future upcoming milestone. |
Description
We would like to have a property on the calcite tree that just allows for selecting the parent, without selecting children. We also want to make sure that this enhancement is accessible.
Currently in the calcite tree, when a parent is expanded / selected, it automatically selects all of the children.
When applied to filters in ArcGIS Online, this creates a scenario that is confusing / overwhelming for users, as there could be many nested filters under a parent. There is also a need to select just the parent in many filter use cases. Current example:
Acceptance Criteria
Allow for a selecting just the parent in a tree without selecting children.
Relevant Info
This example from w3.org of a File Directory for a Treeview illustrates the behaviour we are looking for. Here's a link directly to the codepen example.
Which Component
Calcite tree
Example Use Case
No response
Priority impact
p1 - need for current milestone
Esri team
ArcGIS Online
The text was updated successfully, but these errors were encountered: