Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input Time Zone] Restore skipped offset tests to reflect DST changes #8086

Closed
geospatialem opened this issue Oct 30, 2023 · 2 comments
Closed

[Input Time Zone] Restore skipped offset tests to reflect DST changes #8086

geospatialem opened this issue Oct 30, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Milestone
2023 November Pri...

Comments

@geospatialem
Copy link
Member

Test type

e2e

Which Component(s)

Input Time Zone

Unstable Tests

No response

Test error, if applicable

● calcite-input-time-zone › mode › offset (default) › selects user's matching time zone offset on initialization › selects default time zone for "Europe/London"
● calcite-input-time-zone › mode › offset (default) › allows users to preselect a time zone offset

PR skipped, if applicable

#8085

Additional Info

via @jcfranco: Looks like it's DST-related, as London is used in E2E tests and it had a DST adjustment on 10/29.
@geospatialem geospatialem added testing Issues related to automated or manual testing. p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 3 A day or two of work, likely requires updates to tests. labels Oct 30, 2023
@geospatialem geospatialem added this to the 2023 November Priorities milestone Oct 30, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 31, 2023
This was referenced Oct 31, 2023
Merged
Merged
jcfranco added a commit that referenced this issue Oct 31, 2023
@jcfranco
test(input-time-zone): update screenshot tests to use time zones unaf…
5ead819 
…fected by DST (#8094)

**Related Issue:** #8086 

## Summary

✨📸🧪🔨✨
jcfranco added a commit that referenced this issue Oct 31, 2023
@jcfranco
test(input-time-zone): restore skipped tests (#8093)
d765515 
**Related Issue:** #8086

## Summary

Updates skipped test to use time zones that are unaffected by DST.

✨🧪🔨✨
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 31, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Oct 31, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 16, 2023
@geospatialem
Copy link
Member Author

Verified in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 3 A day or two of work, likely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2023 November Priorities
Development

No branches or pull requests
2 participants
@jcfranco @geospatialem