Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip unstable tests #8085

Merged
merged 1 commit into from
Oct 30, 2023
Merged

test: skip unstable tests #8085

merged 1 commit into from
Oct 30, 2023

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Oct 30, 2023 •
edited
Loading

Related Issue: N/A

Summary

Fails on unrelated PR: #7605

Looks like it's DST-related, as London is used in E2E tests and it had a DST adjustment on 10/2 per @jcfranco

🫤 🤔 🤨 🧐

@github-actions github-actions bot added the testing Issues related to automated or manual testing. label Oct 30, 2023
@Elijbet Elijbet marked this pull request as ready for review October 30, 2023 18:46
@Elijbet Elijbet requested a review from a team as a code owner October 30, 2023 18:46
anveshmekala
anveshmekala approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@anveshmekala anveshmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Please add a PR for reference in summary where the test has failed.

@anveshmekala anveshmekala added the low risk Issues with low risk for consideration in low risk milestones label Oct 30, 2023
@geospatialem geospatialem mentioned this pull request Oct 30, 2023
Closed
@Elijbet
Copy link
Contributor Author

Elijbet commented Oct 30, 2023

👍

Please add a PR for reference in summary where the test has failed.

Done. Thanks Anvesh.

@Elijbet Elijbet added the skip visual snapshots Pull requests that do not need visual regression testing. label Oct 30, 2023
@Elijbet Elijbet merged commit c56bd2e into main Oct 30, 2023
20 of 21 checks passed
@Elijbet Elijbet deleted the elijbet/skip-test-input-time-zone-mode branch October 30, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anveshmekala anveshmekala anveshmekala approved these changes

Assignees

@Elijbet Elijbet

Labels
low risk Issues with low risk for consideration in low risk milestones skip visual snapshots Pull requests that do not need visual regression testing. testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2023 October Priorities - Maintenance...
Development

Successfully merging this pull request may close these issues.
2 participants
@Elijbet @anveshmekala