Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[combobox] selection-mode="single-persist" doesn't work correctly when items have same values #8720

Closed
2 of 6 tasks
dasa opened this issue Feb 9, 2024 · 3 comments
Closed
2 of 6 tasks

[combobox] selection-mode="single-persist" doesn't work correctly when items have same values #8720

dasa opened this issue Feb 9, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-09-30 - 2.13...

Comments

@dasa
Copy link
Member

dasa commented Feb 9, 2024 •
edited
Loading

Check existing issues

Actual Behavior

If there are multiple items with the same values, you can't select between them and they both appear selected when using selection-mode="single-persist". This isn't an issue with "single" selection mode.

image

Expected Behavior

You can select each item individually.

Reproduction Sample

https://codepen.io/dpaddock/pen/oNVPKOz?editors=100

Reproduction Steps

Select Mining, and then try to select Mining 2.

Reproduction Version

2.4.0

Relevant Info

Chrome 121

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

Can workaround for now by using "single" selection mode.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@dasa dasa added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Feb 9, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Feb 9, 2024
@jcfranco jcfranco added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. estimate - 5 A few days of work, definitely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library has workaround Issues have a workaround available in the meantime. and removed needs triage Planning workflow - pending design/dev review. labels Feb 29, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@geospatialem
Copy link
Member

Related #8043

@driskull driskull self-assigned this Sep 20, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Sep 20, 2024
driskull added a commit that referenced this issue Sep 20, 2024
@driskull
fix(combobox): selection-mode="single-persist" correctly selects an i…
998dda1 
…tem when items have same values. #8720
@driskull driskull mentioned this issue Sep 20, 2024
Merged
driskull added a commit that referenced this issue Sep 25, 2024
@driskull
fix(combobox): selection-mode="single-persist" correctly selects an i…
5401ea6 
…tem when items have same values (#10366)

**Related Issue:** #8720

## Summary

- add fix for selecting items with the same value
- add e2e test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 25, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Sep 26, 2024

🍡 Verified locally on dev

The behavior now allows each item to be selected individually.

Screen.Recording.2024-09-26.at.7.55.36.AM.mov

@DitwanP DitwanP closed this as completed Sep 26, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-09-30 - 2.13.0 Sep Main release
Development

No branches or pull requests
5 participants
@jcfranco @dasa @driskull @geospatialem @DitwanP