fix(combobox): correctly select an item with selection-mode=‘single-persist’ when items have the same values
#10366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem when items have same values. #8720
github-actions
bot
added
the
bug
driskull
requested review from
jcfranco,
eriklharper,
macandcheese and
anveshmekala
driskull
added
the
skip visual snapshots
jcfranco
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️
🏄♂️🤙🤙🤙🏄♂️🏄♂️🤙🤙🤙🤙🏄♂️🤙🤙🤙🏄♂️🏄♂️🤙🏄♂️
🏄♂️🤙🏄♂️🏄♂️🤙🏄♂️🤙🏄♂️🏄♂️🤙🏄♂️🤙🏄♂️🏄♂️🤙🏄♂️🤙🏄♂️
🏄♂️🤙🤙🤙🏄♂️🏄♂️🤙🤙🤙🤙🏄♂️🤙🏄♂️🏄♂️🤙🏄♂️🤙🏄♂️
🏄♂️🤙🏄♂️🤙🏄♂️🏄♂️🤙🏄♂️🏄♂️🤙🏄♂️🤙🏄♂️🏄♂️🤙🏄♂️🏄♂️🏄♂️
🏄♂️🤙🏄♂️🏄♂️🤙🏄♂️🤙🏄♂️🏄♂️🤙🏄♂️🤙🤙🤙🏄♂️🏄♂️🤙🏄♂️
🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️🏄♂️
jcfranco
changed the title
selection-mode=‘single-persist’ when items have the same values
benelan
added a commit
that referenced
this pull request
Sep 26, 2024
…lid-border-color * origin/dev: feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388) feat(dialog, panel): Add css properties for background-color (#10387) fix: remove aria-disabled from components where necessary (#10374) feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249) fix(list, filter): fix sync between list items and filtered data (#10342) feat(popover): apply component tokens to arrow (#10386) feat(list-item): add `unavailable` property (#10377) fix(segmented-control): honor appearance, layout and scale when items are added after initialization (#10368) fix(action-pad): fix horizontal action group alignment (#10359) fix(combobox): selection-mode="single-persist" correctly selects an item when items have same values (#10366)
benelan
added a commit
that referenced
this pull request
Sep 26, 2024
…tracking * origin/dev: (40 commits) feat: add parcel parameter (#10384) feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388) feat(dialog, panel): Add css properties for background-color (#10387) fix: remove aria-disabled from components where necessary (#10374) feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249) fix(list, filter): fix sync between list items and filtered data (#10342) feat(popover): apply component tokens to arrow (#10386) feat(list-item): add `unavailable` property (#10377) fix(segmented-control): honor appearance, layout and scale when items are added after initialization (#10368) fix(action-pad): fix horizontal action group alignment (#10359) fix(combobox): selection-mode="single-persist" correctly selects an item when items have same values (#10366) fix(input-time-zone): fix region mode labeling and value mapping (#10345) fix(dropdown): open dropdown on `ArrowDown` & `ArrowUp` keys (#10264) refactor(components): reduce post-migration TypeScript errors (#10356) refactor: do not use Host in functional components (#10352) refactor(tests): reduce TypeScript errors (#10344) feat(alert): add component tokens (#10218) fix(card): properly handle slotted elements (#10378) refactor(panel): remove duplicate tailwind class (#10379) feat(popover, action): add component tokens (#10253) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8720
Summary
BEGIN_COMMIT_OVERRIDE
fix(combobox): correctly select an item with
selection-mode=‘single-persist’when items have the same valuesEND_COMMIT_OVERRIDE