fix: remove aria-disabled from components where necessary #10374

driskull · 2024-09-23T16:56:43Z

Related Issue: #7775

Summary

remove setting aria-disabled where the InteractiveContainer will handle setting aria-disabled
add InteractiveContainer to handle component
- picklist and valuelist also need this but they are deprecated so I didn't update them
some components were setting aria-disabled without toAriaBoolean so they weren't working anyway aria-disabled={this.disabled}
date-picker-month-header was not using toAriaBoolean
update e2e test
After this PR, we can evaluate if we need to update the Interactive.tsx helper.

packages/calcite-components/src/components/button/button.tsx

driskull · 2024-09-23T17:05:26Z

After this PR, the only remaining work would be to verify if we need to remove setting aria-disabled on the host with the Interactive helper.

driskull · 2024-09-23T17:07:17Z

packages/calcite-components/src/components/card/card.tsx

@@ -339,7 +339,6 @@ export class Card
        <InteractiveContainer disabled={this.disabled}>
          <div
            aria-checked={this.selectionMode !== "none" ? toAriaBoolean(this.selected) : undefined}
-            aria-disabled={this.disabled}


This one wasn't using toAriaBoolean so it wasn't working. I think that means we can safely remove it.

driskull · 2024-09-24T16:26:14Z

packages/calcite-components/src/components/card-group/card-group.tsx

@@ -235,12 +235,7 @@ export class CardGroup implements InteractiveComponent, LoadableComponent {
    return (
      <Host>
        <InteractiveContainer disabled={this.disabled}>
-          <div
-            aria-disabled={toAriaBoolean(this.disabled)}


Not needed because the InteractiveContainer will handle setting aria-disabled

driskull · 2024-09-24T16:26:38Z

packages/calcite-components/src/components/chip-group/chip-group.tsx

@@ -275,12 +275,7 @@ export class ChipGroup implements InteractiveComponent {

    return (
      <InteractiveContainer disabled={disabled}>
-        <div
-          aria-disabled={toAriaBoolean(disabled)}


Not needed because the InteractiveContainer will handle setting aria-disabled

driskull · 2024-09-24T16:30:37Z

packages/calcite-components/src/components/chip/chip.tsx

@@ -413,7 +413,6 @@ export class Chip
                ? toAriaBoolean(this.selected)
                : undefined
            }
-            aria-disabled={disableInteraction ? toAriaBoolean(disabled) : undefined}


This one was only setting aria-disabled when disabled was true anyway. Not sure why the disabledInteraction is being tested here unless we do this:

aria-disabled={disableInteraction ? toAriaBoolean(disableInteraction) : undefined}

I think we can safely remove this and rely on InteractiveContainer to set aria-disabled.

driskull · 2024-09-24T16:31:24Z

packages/calcite-components/src/components/date-picker-day/date-picker-day.tsx

@@ -181,7 +181,6 @@ export class DatePickerDay implements InteractiveComponent, LoadableComponent {

    return (
      <Host
-        aria-disabled={toAriaBoolean(this.disabled)}


Not needed because the InteractiveContainer will handle setting aria-disabled

driskull · 2024-09-24T16:32:09Z

packages/calcite-components/src/components/slider/slider.tsx

@@ -438,7 +438,6 @@ export class Slider

    return (
      <div
-        aria-disabled={this.disabled}


This one wasn't using toAriaBoolean so it wasn't working. I think that means we can safely remove it.

driskull · 2024-09-24T16:32:13Z

packages/calcite-components/src/components/table-cell/table-cell.tsx

@@ -222,7 +222,6 @@ export class TableCell
      <Host>
        <InteractiveContainer disabled={this.disabled}>
          <td
-            aria-disabled={this.disabled}


This one wasn't using toAriaBoolean so it wasn't working. I think that means we can safely remove it.

driskull · 2024-09-24T16:32:17Z

packages/calcite-components/src/components/table-row/table-row.tsx

@@ -409,7 +409,6 @@ export class TableRow implements InteractiveComponent, LocalizedComponent {
      <Host>
        <InteractiveContainer disabled={this.disabled}>
          <tr
-            aria-disabled={this.disabled}


This one wasn't using toAriaBoolean so it wasn't working. I think that means we can safely remove it.

jcfranco

Great catches, @driskull! ✨🎣✨

🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅
🏅🎣🏅🏅🏅🎣🏅🏅🎣🎣🏅🏅🎣🎣🎣🏅🏅🎣🎣🎣🏅🎣🎣🎣🎣🏅🎣🏅
🏅🎣🎣🏅🏅🎣🏅🎣🏅🏅🎣🏅🏅🎣🏅🏅🎣🏅🏅🏅🏅🎣🏅🏅🏅🏅🎣🏅
🏅🎣🏅🎣🏅🎣🏅🎣🏅🏅🎣🏅🏅🎣🏅🏅🎣🏅🏅🏅🏅🎣🎣🎣🏅🏅🎣🏅
🏅🎣🏅🏅🎣🎣🏅🎣🏅🏅🎣🏅🏅🎣🏅🏅🎣🏅🏅🏅🏅🎣🏅🏅🏅🏅🏅🏅
🏅🎣🏅🏅🏅🎣🏅🏅🎣🎣🏅🏅🎣🎣🎣🏅🏅🎣🎣🎣🏅🎣🎣🎣🎣🏅🎣🏅
🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅🏅

...ages/calcite-components/src/components/date-picker-month-header/date-picker-month-header.tsx

packages/calcite-components/src/components/button/button.tsx

# Conflicts: # packages/calcite-components/src/components/button/button.tsx

driskull · 2024-09-25T21:00:14Z

@geospatialem could you review these changes?

geospatialem

One comment WRT aria-busy and if our intent is to have the component with the disabled attribute present when loading

packages/calcite-components/src/components/button/button.tsx

…lid-border-color * origin/dev: feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388) feat(dialog, panel): Add css properties for background-color (#10387) fix: remove aria-disabled from components where necessary (#10374) feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249) fix(list, filter): fix sync between list items and filtered data (#10342) feat(popover): apply component tokens to arrow (#10386) feat(list-item): add `unavailable` property (#10377) fix(segmented-control): honor appearance, layout and scale when items are added after initialization (#10368) fix(action-pad): fix horizontal action group alignment (#10359) fix(combobox): selection-mode="single-persist" correctly selects an item when items have same values (#10366)

…tracking * origin/dev: (40 commits) feat: add parcel parameter (#10384) feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388) feat(dialog, panel): Add css properties for background-color (#10387) fix: remove aria-disabled from components where necessary (#10374) feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249) fix(list, filter): fix sync between list items and filtered data (#10342) feat(popover): apply component tokens to arrow (#10386) feat(list-item): add `unavailable` property (#10377) fix(segmented-control): honor appearance, layout and scale when items are added after initialization (#10368) fix(action-pad): fix horizontal action group alignment (#10359) fix(combobox): selection-mode="single-persist" correctly selects an item when items have same values (#10366) fix(input-time-zone): fix region mode labeling and value mapping (#10345) fix(dropdown): open dropdown on `ArrowDown` & `ArrowUp` keys (#10264) refactor(components): reduce post-migration TypeScript errors (#10356) refactor: do not use Host in functional components (#10352) refactor(tests): reduce TypeScript errors (#10344) feat(alert): add component tokens (#10218) fix(card): properly handle slotted elements (#10378) refactor(panel): remove duplicate tailwind class (#10379) feat(popover, action): add component tokens (#10253) ...

…estone-estimates * origin/dev: (26 commits) test: fix `window.getComputedStyle` arguments (#10424) test(card): remove redundant spy and setup wrapper element (#10429) test(heading): avoid `newSpecPage` usage to ease Lumina migration (#10431) refactor(themed): drop broken, unused, regexp arg support (#10425) docs: component token description consistency (#10430) refactor: prevent mixed Sass mixed declaration warnings (#10426) deprecate: deprecate `enforce-ref-last-prop` rule (#10421) chore(actions): add custom `deprecate` type to semantic-pr check (#10427) chore(issue templates): add arcgis data pipelines to team dropdown (#10418) fix(tooltip): closed tooltips should not reappear (#10420) feat: add dashboard-graph (#10417) fix(input-time-zone): fix region mode quirks after update (#10413) fix(text-area): ensure border-color token doesn't override invalid styles (#10390) ci(changelog): add deprecation commits to changelog automation (#10346) fix: properly set aria attributes on components (#10404) feat: add parcel parameter (#10384) feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388) feat(dialog, panel): Add css properties for background-color (#10387) fix: remove aria-disabled from components where necessary (#10374) feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249) ...

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.32.0</summary> ## [3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0) (2024-09-30) ### Features * Add 3d building, 3d building parameter, divide, parcel, spaces, spaces parameter, square brackets x, n variable, zoning parameter ([#10373](#10373)) ([3ed86ce](3ed86ce)) * Add content inline right ([#10338](#10338)) ([b4530ab](b4530ab)) * Add dashboard-graph ([#10417](#10417)) ([737085a](737085a)) * Add justify ([#10272](#10272)) ([3d6c013](3d6c013)) * Add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history ([#10305](#10305)) ([1e31d43](1e31d43)) * Add parcel parameter ([#10384](#10384)) ([c99be67](c99be67)) * Add trace path and trace path complete ([#10196](#10196)) ([c37ced5](c37ced5)) * Add validate ([#10354](#10354)) ([4160af1](4160af1)) * Add web adaptor ([#10286](#10286)) ([791fd78](791fd78)) * Added connection end left, connection end right, connection middle, connection to connection ([#10198](#10198)) ([3d0f703](3d0f703)) ### Bug Fixes * Correct non-standard filled icon names ([#10309](#10309)) ([7d67334](7d67334)) </details> <details><summary>@esri/eslint-plugin-calcite-components: 1.2.1</summary> ## [1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1) (2024-09-30) ### Deprecations * Deprecate `enforce-ref-last-prop` rule ([#10421](#10421)) ([5fde52d](5fde52d)) </details> <details><summary>@esri/calcite-components: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0) (2024-09-30) ### Features * **accordion-item:** Update component tokens ([ca932b5](ca932b5)) * **action-group, block, panel:** Add `menuPlacement` and `menuFlipPlacements` properties ([#10249](#10249)) ([5ba3112](5ba3112)) * **alert:** Add component tokens ([#10218](#10218)) ([550427b](550427b)) * **alert:** Apply --calcite-alert-corner-radius to internal close button ([#10388](#10388)) ([f50c170](f50c170)) * **avatar:** Add component tokens ([#10280](#10280)) ([f8f881b](f8f881b)) * **carousel:** Improve support for high item counts ([#10315](#10315)) ([6ad2612](6ad2612)) * **checkbox:** Add component tokens ([#10221](#10221)) ([1d87dcf](1d87dcf)) * **chip:** Add component tokens ([#10179](#10179)) ([ff82570](ff82570)) * **dialog, panel:** Add css properties for background-color ([#10387](#10387)) ([d725293](d725293)) * **handle:** Add component tokens ([#10262](#10262)) ([5e73b44](5e73b44)) * **input, input-number, input-text:** Add prefix and suffix width css tokens ([#10206](#10206)) ([7a6ee82](7a6ee82)) * **list-item:** Add `unavailable` property ([#10377](#10377)) ([9332733](9332733)) * **panel:** Improve panel header layout ([#10446](#10446)) ([12f1476](12f1476)) * **popover, action:** Add component tokens ([#10253](#10253)) ([80e8112](80e8112)) * **popover:** Apply component tokens to arrow ([#10386](#10386)) ([2d19268](2d19268)) * **progress:** Add component tokens ([#10267](#10267)) ([8c1259f](8c1259f)) * **text-area:** Add component tokens ([#10343](#10343)) ([d2504b7](d2504b7)) ### Bug Fixes * **action-pad:** Fix horizontal action group alignment ([#10359](#10359)) ([7b03745](7b03745)) * **action-pad:** Update layout on action-group elements slotted after initialization ([#10355](#10355)) ([cf139fa](cf139fa)) * **action:** Prefer `disabled` in favor of `aria-disabled` ([#10367](#10367)) ([1895c07](1895c07)) * **card:** Properly handle slotted elements ([#10378](#10378)) ([99a7148](99a7148)) * **combobox:** Correctly select an item with `selection-mode=‘single-persist’` when items have the same values ([5401ea6](5401ea6)) * **dialog:** Only prevent default on escape key when escapeDisabled is true ([#10336](#10336)) ([0083630](0083630)) * **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys ([#10264](#10264)) ([98548e4](98548e4)) * **input-time-zone:** Fix region mode labeling and value mapping ([#10345](#10345)) ([cf36299](cf36299)) * **input-time-zone:** Fix region mode quirks after update ([#10413](#10413)) ([c137d1f](c137d1f)) * **list, filter:** Fix sync between list items and filtered data ([#10342](#10342)) ([9a66601](9a66601)) * **panel:** Initially closed panel should be hidden ([#10308](#10308)) ([46de96b](46de96b)) * **popover:** Update focus trap elements on mutation observer ([#10357](#10357)) ([725254a](725254a)) * Properly set aria attributes on components ([#10404](#10404)) ([864f3e3](864f3e3)) * Remove aria-disabled from components where necessary ([#10374](#10374)) ([4f8c16c](4f8c16c)) * **segmented-control:** Honor appearance, layout and scale when items are added after initialization ([#10368](#10368)) ([98177f0](98177f0)) * **shell:** Fix z-index of slotted popover elements ([#10325](#10325)) ([7fe1601](7fe1601)) * **text-area:** Ensure border-color token doesn't override invalid styles ([#10390](#10390)) ([699e166](699e166)) * **tooltip:** Closed tooltips should not reappear ([#10420](#10420)) ([a2f3925](a2f3925)) ### Deprecations * **checkbox, radio-button:** Deprecate 'guid' properties ([#10445](#10445)) ([9729ccf](9729ccf)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0 * devDependencies * @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to 1.2.1 </details> <details><summary>@esri/calcite-components-angular: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> <details><summary>@esri/calcite-components-react: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.32.0</summary> ## [3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0) (2024-09-30) ### Features * Add 3d building, 3d building parameter, divide, parcel, spaces, spaces parameter, square brackets x, n variable, zoning parameter ([#10373](#10373)) ([3ed86ce](3ed86ce)) * Add content inline right ([#10338](#10338)) ([b4530ab](b4530ab)) * Add dashboard-graph ([#10417](#10417)) ([737085a](737085a)) * Add justify ([#10272](#10272)) ([3d6c013](3d6c013)) * Add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history ([#10305](#10305)) ([1e31d43](1e31d43)) * Add parcel parameter ([#10384](#10384)) ([c99be67](c99be67)) * Add trace path and trace path complete ([#10196](#10196)) ([c37ced5](c37ced5)) * Add validate ([#10354](#10354)) ([4160af1](4160af1)) * Add web adaptor ([#10286](#10286)) ([791fd78](791fd78)) * Added connection end left, connection end right, connection middle, connection to connection ([#10198](#10198)) ([3d0f703](3d0f703)) ### Bug Fixes * Correct non-standard filled icon names ([#10309](#10309)) ([7d67334](7d67334)) </details> <details><summary>@esri/eslint-plugin-calcite-components: 1.2.1</summary> ## [1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1) (2024-09-30) ### Deprecations * Deprecate `enforce-ref-last-prop` rule ([#10421](#10421)) ([5fde52d](5fde52d)) </details> <details><summary>@esri/calcite-components: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0) (2024-09-30) ### Features * **accordion-item:** Update component tokens ([ca932b5](ca932b5)) * **action-group, block, panel:** Add `menuPlacement` and `menuFlipPlacements` properties ([#10249](#10249)) ([5ba3112](5ba3112)) * **alert:** Add component tokens ([#10218](#10218)) ([550427b](550427b)) * **alert:** Apply --calcite-alert-corner-radius to internal close button ([#10388](#10388)) ([f50c170](f50c170)) * **avatar:** Add component tokens ([#10280](#10280)) ([f8f881b](f8f881b)) * **carousel:** Improve support for high item counts ([#10315](#10315)) ([6ad2612](6ad2612)) * **checkbox:** Add component tokens ([#10221](#10221)) ([1d87dcf](1d87dcf)) * **chip:** Add component tokens ([#10179](#10179)) ([ff82570](ff82570)) * **dialog, panel:** Add css properties for background-color ([#10387](#10387)) ([d725293](d725293)) * **handle:** Add component tokens ([#10262](#10262)) ([5e73b44](5e73b44)) * **input, input-number, input-text:** Add prefix and suffix width css tokens ([#10206](#10206)) ([7a6ee82](7a6ee82)) * **list-item:** Add `unavailable` property ([#10377](#10377)) ([9332733](9332733)) * **panel:** Improve panel header layout ([#10446](#10446)) ([12f1476](12f1476)) * **popover, action:** Add component tokens ([#10253](#10253)) ([80e8112](80e8112)) * **popover:** Apply component tokens to arrow ([#10386](#10386)) ([2d19268](2d19268)) * **progress:** Add component tokens ([#10267](#10267)) ([8c1259f](8c1259f)) * **text-area:** Add component tokens ([#10343](#10343)) ([d2504b7](d2504b7)) ### Bug Fixes * **action-pad:** Fix horizontal action group alignment ([#10359](#10359)) ([7b03745](7b03745)) * **action-pad:** Update layout on action-group elements slotted after initialization ([#10355](#10355)) ([cf139fa](cf139fa)) * **action:** Prefer `disabled` in favor of `aria-disabled` ([#10367](#10367)) ([1895c07](1895c07)) * **card:** Properly handle slotted elements ([#10378](#10378)) ([99a7148](99a7148)) * **combobox:** Correctly select an item with `selection-mode=‘single-persist’` when items have the same values ([5401ea6](5401ea6)) * **dialog:** Only prevent default on escape key when escapeDisabled is true ([#10336](#10336)) ([0083630](0083630)) * **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys ([#10264](#10264)) ([98548e4](98548e4)) * **input-time-zone:** Fix region mode labeling and value mapping ([#10345](#10345)) ([cf36299](cf36299)) * **input-time-zone:** Fix region mode quirks after update ([#10413](#10413)) ([c137d1f](c137d1f)) * **list, filter:** Fix sync between list items and filtered data ([#10342](#10342)) ([9a66601](9a66601)) * **panel:** Initially closed panel should be hidden ([#10308](#10308)) ([46de96b](46de96b)) * **popover:** Update focus trap elements on mutation observer ([#10357](#10357)) ([725254a](725254a)) * Properly set aria attributes on components ([#10404](#10404)) ([864f3e3](864f3e3)) * Remove aria-disabled from components where necessary ([#10374](#10374)) ([4f8c16c](4f8c16c)) * **segmented-control:** Honor appearance, layout and scale when items are added after initialization ([#10368](#10368)) ([98177f0](98177f0)) * **shell:** Fix z-index of slotted popover elements ([#10325](#10325)) ([7fe1601](7fe1601)) * **text-area:** Ensure border-color token doesn't override invalid styles ([#10390](#10390)) ([699e166](699e166)) * **tooltip:** Closed tooltips should not reappear ([#10420](#10420)) ([a2f3925](a2f3925)) ### Deprecations * **checkbox, radio-button:** Deprecate 'guid' properties ([#10445](#10445)) ([9729ccf](9729ccf)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0 * devDependencies * @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to 1.2.1 </details> <details><summary>@esri/calcite-components-angular: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> <details><summary>@esri/calcite-components-react: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

fix: remove aria-disabled from components where necessary. #7775

cfa7e39

github-actions bot assigned driskull Sep 23, 2024

github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Sep 23, 2024

driskull commented Sep 23, 2024

View reviewed changes

packages/calcite-components/src/components/button/button.tsx Show resolved Hide resolved

driskull marked this pull request as ready for review September 23, 2024 16:59

driskull requested a review from jcfranco September 23, 2024 17:00

fix date picker month header

dcb1810

fix comment

0390032

driskull commented Sep 23, 2024

View reviewed changes

fix test

f233bfd

geospatialem mentioned this pull request Sep 23, 2024

Epic: Component a11y consistency with disabled and aria-disabled attributes (2036570545) #7775

Open

driskull commented Sep 24, 2024

View reviewed changes

driskull added this to the 2024-09-30 - 2.13.0 Sep Main release milestone Sep 25, 2024

jcfranco approved these changes Sep 25, 2024

View reviewed changes

...ages/calcite-components/src/components/date-picker-month-header/date-picker-month-header.tsx Outdated Show resolved Hide resolved

packages/calcite-components/src/components/button/button.tsx Show resolved Hide resolved

revert date picker changes, review fixes

54f76ce

driskull requested a review from geospatialem September 25, 2024 20:59

Merge branch 'dev' into dris0000/aria-disabled-cleanup

0da7577

# Conflicts: # packages/calcite-components/src/components/button/button.tsx

driskull requested a review from benelan as a code owner September 25, 2024 21:00

driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Sep 25, 2024

Update .stylelintrc.cjs

3290057

geospatialem reviewed Sep 25, 2024

View reviewed changes

packages/calcite-components/src/components/button/button.tsx Show resolved Hide resolved

cleanup

05a4157

driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed skip visual snapshots Pull requests that do not need visual regression testing. labels Sep 25, 2024

driskull merged commit 4f8c16c into dev Sep 25, 2024
15 checks passed

driskull deleted the dris0000/aria-disabled-cleanup branch September 25, 2024 23:10

calcite-admin mentioned this pull request Sep 30, 2024

chore: release main #10457

Merged

benelan mentioned this pull request Oct 1, 2024

chore: release main (#10457) #10461

Closed

calcite-admin mentioned this pull request Oct 1, 2024

chore: release main (#10457) #10463

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove aria-disabled from components where necessary #10374

fix: remove aria-disabled from components where necessary #10374

driskull commented Sep 23, 2024 •

edited

Loading

driskull commented Sep 23, 2024

driskull Sep 23, 2024 •

edited

Loading

driskull Sep 24, 2024

driskull Sep 24, 2024

driskull Sep 24, 2024 •

edited

Loading

driskull Sep 24, 2024

driskull Sep 24, 2024 •

edited

Loading

driskull Sep 24, 2024 •

edited

Loading

driskull Sep 24, 2024 •

edited

Loading

jcfranco left a comment

driskull commented Sep 25, 2024

geospatialem left a comment

fix: remove aria-disabled from components where necessary #10374

fix: remove aria-disabled from components where necessary #10374

Conversation

driskull commented Sep 23, 2024 • edited Loading

Summary

driskull commented Sep 23, 2024

driskull Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

driskull Sep 24, 2024

Choose a reason for hiding this comment

driskull Sep 24, 2024

Choose a reason for hiding this comment

driskull Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

driskull Sep 24, 2024

Choose a reason for hiding this comment

driskull Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

driskull Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

driskull Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

jcfranco left a comment

Choose a reason for hiding this comment

driskull commented Sep 25, 2024

geospatialem left a comment

Choose a reason for hiding this comment

driskull commented Sep 23, 2024 •

edited

Loading

driskull Sep 23, 2024 •

edited

Loading

driskull Sep 24, 2024 •

edited

Loading

driskull Sep 24, 2024 •

edited

Loading

driskull Sep 24, 2024 •

edited

Loading

driskull Sep 24, 2024 •

edited

Loading