Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dropdown): fix dropdown E2E suite grouping #8319

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 1, 2023

Related Issue: N/A

Summary

✨🧪🔧✨

@github-actions github-actions bot added the testing Issues related to automated or manual testing. label Dec 1, 2023
@jcfranco
Copy link
Member Author

jcfranco commented Dec 1, 2023

Hiding whitespace should make this simpler to review: https://github.com/Esri/calcite-design-system/pull/8319/files?diff=split&w=1.

@jcfranco jcfranco marked this pull request as ready for review December 1, 2023 21:53
@jcfranco jcfranco requested a review from a team as a code owner December 1, 2023 21:53
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 1, 2023
@jcfranco jcfranco requested a review from Elijbet December 1, 2023 21:53
@@ -101,6 +101,6 @@ All components have been constructed to inherit their `font-family`. This enable

The Esri color palette can be found [here](https://esri.github.io/calcite-colors/).

**Discussed In**:
__Discussed In__:
Copy link
Member Author

@jcfranco jcfranco Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was autofixed after merging main.

@jcfranco jcfranco merged commit c8230d0 into main Dec 6, 2023
11 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-dropdown-e2e-test-nesting branch December 6, 2023 16:50
@github-actions github-actions bot added this to the 2023 December Priorities milestone Dec 6, 2023
benelan added a commit that referenced this pull request Dec 7, 2023
…ssage

* origin/main: (22 commits)
  build(deps): update dependency @types/lodash-es to v4.17.12 (#8347)
  build(deps): update dependency @types/semver to v7.5.6 (#8348)
  ci: stop formatting components.d.ts (#8358)
  build(deps): update dependency @types/shell-quote to v1.7.5 (#8349)
  ci: remove workarounds no longer needed with Stencil v4 (#8325)
  refactor(input, input-number, input-text): avoid redundant `:host` (#8163)
  fix(color-context tokens): only apply when `.calcite-mode-auto` is applied (#8344)
  test(dropdown): fix dropdown E2E suite grouping (#8319)
  build(deps): update dependency @types/jest-axe to v3.5.9 (#8346)
  refactor(dropdown): remove obsolete logic (#8321)
  fix(action-menu):  fix closing action menu after a drag occurs (#8339)
  fix(shell, shell-panel): support resizing shell panel when there is an iframe slotted in shell content (#8317)
  chore(dropdown): update demo page to use selected vs active (removed) (#8322)
  fix(action-menu): Filter hidden or disabled actions via keyboard. (#8336)
  build(deps): update dependency @esri/calcite-ui-icons to v3.25.1 (#8331)
  build(deps): update dependency @types/color to v3.0.6 (#8332)
  build(deps): update dependency @types/dedent to v0.7.2 (#8334)
  build(deps): update dependency @types/estree to v1.0.5 (#8335)
  chore(demos): update outdated CSS variable names after token breaking changes (#8333)
  build(deps): update dependency @tokens-studio/sd-transforms to v0.12.1 (#8146)
  ...
alisonailea pushed a commit that referenced this pull request Dec 7, 2023
**Related Issue:** N/A

## Summary

✨🧪🔧✨
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip visual snapshots Pull requests that do not need visual regression testing. testing Issues related to automated or manual testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants