ci: remove workarounds no longer needed with Stencil v4 #8325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelan
requested review from
jcfranco,
driskull and
geospatialem
as code owners
github-actions
bot
added
the
chore
alisonailea
approved these changes
Dec 4, 2023
jcfranco
approved these changes
Dec 5, 2023
benelan
added
the
skip visual snapshots
benelan
added a commit
that referenced
this pull request
Dec 7, 2023
…ssage * origin/main: (22 commits) build(deps): update dependency @types/lodash-es to v4.17.12 (#8347) build(deps): update dependency @types/semver to v7.5.6 (#8348) ci: stop formatting components.d.ts (#8358) build(deps): update dependency @types/shell-quote to v1.7.5 (#8349) ci: remove workarounds no longer needed with Stencil v4 (#8325) refactor(input, input-number, input-text): avoid redundant `:host` (#8163) fix(color-context tokens): only apply when `.calcite-mode-auto` is applied (#8344) test(dropdown): fix dropdown E2E suite grouping (#8319) build(deps): update dependency @types/jest-axe to v3.5.9 (#8346) refactor(dropdown): remove obsolete logic (#8321) fix(action-menu): fix closing action menu after a drag occurs (#8339) fix(shell, shell-panel): support resizing shell panel when there is an iframe slotted in shell content (#8317) chore(dropdown): update demo page to use selected vs active (removed) (#8322) fix(action-menu): Filter hidden or disabled actions via keyboard. (#8336) build(deps): update dependency @esri/calcite-ui-icons to v3.25.1 (#8331) build(deps): update dependency @types/color to v3.0.6 (#8332) build(deps): update dependency @types/dedent to v0.7.2 (#8334) build(deps): update dependency @types/estree to v1.0.5 (#8335) chore(demos): update outdated CSS variable names after token breaking changes (#8333) build(deps): update dependency @tokens-studio/sd-transforms to v0.12.1 (#8146) ...
alisonailea
pushed a commit
that referenced
this pull request
Dec 7, 2023
## Summary
Removes some workarounds that are no longer needed. The first types test
was because we didn't commit `components.d.ts` and needed to build twice
to get the correct types. After updating to Stencil v4, we started
getting JSDOM type errors from that test.
```
../../node_modules/puppeteer/lib/types.d.ts:7584:5 - error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.
7584 #private;
~~~~~~~~
Found 22 errors in the same file, starting at: ../../node_modules/puppeteer/lib/types.d.ts:33
```
It looks like it is using the wrong tsconfig or something, because we
are above ES2015. Alternatively we could use `skipLibCheck`, but that
can cause a variety of issues, especially with monorepos.
Also removes the extra build that happens before publishing CC. It was
originally for the `component.d.ts` types issue and to make sure the
version is correct in the source code preamble. Now that we don't have
the types issue anymore, we can move the versioning before the first
build in the CI to get rid of the second build.
benelan
added a commit
that referenced
this pull request
Dec 7, 2023
**Related Issue:** #8325 ## Summary Resolves [an error](https://github.com/Esri/calcite-design-system/actions/runs/7132693857/job/19423776955#step:4:39) in the `next` deployment CI, which was trying to use `ts-node` before it was installed. The issue was introduced in the PR linked above, which was fixing a [different error](https://github.com/Esri/calcite-design-system/actions/runs/7119908955/job/19386029658#step:5:545) in the `next` deployment CI.
benelan
added a commit
that referenced
this pull request
Dec 14, 2023
**Related Issue:** #8421 ## Summary Ensure the build used for `next` releases includes patches. This fixes a regression caused by #8325, where we removed the extra build on prepublish. The extra build was fixing some issues caused by `npm run test:prerender`, where a build occurred that didn't run pre/post build scripts, including the ESM resolution patch added in #5145.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes some workarounds that are no longer needed. The first types test was because we didn't commit
components.d.tsand needed to build twice to get the correct types. After updating to Stencil v4, we started getting JSDOM type errors from that test.It looks like it is using the wrong tsconfig or something, because we are above ES2015. Alternatively we could use
skipLibCheck, but that can cause a variety of issues, especially with monorepos.Also removes the extra build that happens before publishing CC. It was originally for the
component.d.tstypes issue and to make sure the version is correct in the source code preamble. Now that we don't have the types issue anymore, we can move the versioning before the first build in the CI to get rid of the second build.