Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ensure patches run after prerender test build #8423

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

benelan
Copy link
Member

@benelan benelan commented Dec 14, 2023

Related Issue: #8421

Summary

Ensure the build used for next releases includes patches. This fixes a regression caused by #8325, where we removed the extra build on prepublish. The extra build was fixing some issues caused by npm run test:prerender, where a build occurred that didn't run pre/post build scripts, including the ESM resolution patch added in #5145.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Dec 14, 2023
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 14, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖🔨

@benelan benelan merged commit 1c4e6ce into main Dec 14, 2023
13 checks passed
@benelan benelan deleted the benelan/8421-ensure-postbuild-runs branch December 14, 2023 17:03
@github-actions github-actions bot added this to the 2023 December Priorities milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants