Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ethereum tests version #119

Merged
merged 11 commits into from
Feb 16, 2024
Merged

Conversation

Stefan-Ethernal
Copy link

@Stefan-Ethernal Stefan-Ethernal commented Feb 15, 2024

Description

This PR uses the newest release tag from official ethereum EVM tests, and fixes tests folder and files loading which did not load all the tests to be executed.

It also adds logging about test execution and skips two long running tests:

  • loop_mul
  • CREATEBlake2f_MaxRounds.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/bump-ethereum-tests branch 2 times, most recently from ab07c11 to edbeb19 Compare February 15, 2024 09:32
@Stefan-Ethernal Stefan-Ethernal changed the base branch from feature/berlin to london-tests-fix February 15, 2024 10:51
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/bump-ethereum-tests branch from 49e4ef4 to 611950d Compare February 15, 2024 11:43
@goran-ethernal goran-ethernal marked this pull request as ready for review February 16, 2024 14:50
@goran-ethernal goran-ethernal self-requested a review February 16, 2024 14:51
@goran-ethernal goran-ethernal force-pushed the feat/bump-ethereum-tests branch from 28f5848 to a2307d4 Compare February 16, 2024 15:25
@goran-ethernal goran-ethernal changed the base branch from london-tests-fix to feature/berlin February 16, 2024 15:25
@goran-ethernal goran-ethernal merged commit d24f06f into feature/berlin Feb 16, 2024
8 of 9 checks passed
@goran-ethernal goran-ethernal deleted the feat/bump-ethereum-tests branch February 16, 2024 16:22
@goran-ethernal goran-ethernal mentioned this pull request Feb 19, 2024
11 tasks
goran-ethernal added a commit that referenced this pull request Feb 19, 2024
* EIP-2565 Implementation (0xPolygon#1704)

* implemented EIP-2565

* fixed linting error

* fixed linting error

* fixed TestModExpWithEIP2565

* resolved comments

* resolved comments

* resolved merge conflicts

* Eip 2929 (0xPolygon#1748)

* implemented changes for EIP-2929 (access list)

* added missing files

* fixed unit test Test_opCall

* populate access_list with precompiles only if eip-2929 is activated

* added address to access list for Balance opcode

* added test cases and for EIP-2929 and also call stack output

* changed structure of access list and removed some comments

* fixed linting errors

* fixed AddSlot method

* added test cases for access list

* removed call stack output for Test_Transition_EIP2929

* corrected indentation

* fixed linting errors

* fixed linting errors

* fixed Test_opReturnDataCopy

* removed ActivePrecompile Address slice

* changed the const name

* changed the const name in comments

* change the AddAddress function to a variadic function

* refactored

* added test cases for SLOAD opcode

* fixed linting errors

* refactored code

* resolved merge conflicts

* fixed EIP-2929 test

* Rebase fix

* `Berlin` fork implementation (#81)

* Berlin implementation

* Fix tests

* Lint fix

* Lint fix part 2

* Bug fixes

* Lint fix

* Legacy e2e tests fix

* Unmarshal fix

* Tx signer fix

* Use requires instead of Fatalf

* Pass the TestLondonSignerSender

* Cleanup precompile addresses

* TxSigner fix

* Fix precompiles addresses access in unit test

* Order tx types

* Address comments

---------

Co-authored-by: Stefan Negovanović <stefan@ethernal.tech>

* Rebase fix

* Berlin fixes (#86)

* Add journal to contract access list changes

* small fix on journal

* remove access list from state

* Fix build

* Remove commented code

* Add access list to state_test_util

* Include BerlinToLondon tests as well

* Minor change

---------

Co-authored-by: Stefan Negovanović <stefan@ethernal.tech>

* Use `btcec v2` lib for `ECDSA` keys manipulation (#105)

* Use btcec v2 lib for ECDSA keys manipulation

* Fix test

* Remove key from stake manager

* Warning fix (loop variable capture)

* Bump Ethereum tests version (#119)

* Bump Ethereum tests version

* Linter fixes

* Skip loopMul and minor refactoring

* Refactor Ethereum tests files resolution

* Provide EIP 3607 to each fork config

* Audit duration of each test

* Add detailed logging and skip CREATEBlake2f_MaxRounds test

* Remove -v flag

* small fixes

* fix

* Lint fix

---------

Co-authored-by: Goran Rojovic <goran.rojovic@ethernal.tech>

* London test fixes (#111)

* Tests fixes

* SelfDestruct fix

* Rebase fix

* Journaling fix

* Tests fix

* e2e fix

* subGasLimit fix

* Fix

* Skip CheckEIP1559 e2e test

* Remove auxState field from Transition and use NewTransition function

* increase timeout for UT

* Suppress linting warnings

* underflow test fix

* Revert make file

* Remove panic

* Use %d in the error formatting

---------

Co-authored-by: Stefan Negovanović <stefan@ethernal.tech>

---------

Co-authored-by: Rachit Sonthalia <54906134+rachit77@users.noreply.github.com>
Co-authored-by: Goran Rojovic <goran.rojovic@ethernal.tech>
Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants