Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install daft on M2 Pro mac #2211

Closed
universalmind303 opened this issue Apr 30, 2024 · 2 comments · Fixed by #2213
Closed

Unable to install daft on M2 Pro mac #2211

universalmind303 opened this issue Apr 30, 2024 · 2 comments · Fixed by #2213
Assignees

Comments

@universalmind303
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

> python -m pip install -U getdaft
> python -c "import daft";                                                                                            04/30/2024 05:06:12 PM
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/me/Development/daft-example/.venv/lib/python3.11/site-packages/daft/__init__.py", line 26, in <module>
    from daft.daft import build_type as _build_type
ImportError: dlopen(/Users/me/Development/daft-example/.venv/lib/python3.11/site-packages/daft/daft.abi3.so, 0x0002): Library not loaded: /opt/homebrew/opt/xz/lib/liblzma.5.dylib
  Referenced from: <C63B9E6D-3659-33B8-8821-FB3C4AFFE625> /Users/me/Development/daft-example/.venv/lib/python3.11/site-packages/daft/daft.abi3.so
  Reason: tried: '/opt/homebrew/opt/xz/lib/liblzma.5.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e' or 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/xz/lib/liblzma.5.dylib' (no such file), '/opt/homebrew/opt/xz/lib/liblzma.5.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e' or 'arm64'))

Expected behavior
doesn't panic on import

Additional context
we can statically link liblzma to avoid this all together.
I previously opened up some issues in various repos for similar issues

@samster25
Copy link
Member

@universalmind303 Yeah that would be great if you can push up a PR for this. I didn't realize we dynamically link to liblzma. on Linux we don't seem to have it

	linux-vdso.so.1 (0x00007ffca55ad000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f80f8ee3000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f80f8dfc000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f80f8bd3000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f8100b61000)

@universalmind303
Copy link
Contributor Author

@samster25 feel free to assign to me and I can get a PR together pretty quick

samster25 pushed a commit that referenced this issue Apr 30, 2024
closes #2211 

```sh
> otool -L daft/daft.abi3.so | grep 'liblzma'   
# empty
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants