Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature flag to statically link liblzma #9256

Closed
universalmind303 opened this issue Feb 17, 2024 · 3 comments · Fixed by #9311
Closed

feature flag to statically link liblzma #9256

universalmind303 opened this issue Feb 17, 2024 · 3 comments · Fixed by #9311
Labels
enhancement New feature or request

Comments

@universalmind303
Copy link
Contributor

Is your feature request related to a problem or challenge?

datafusion automatically dynamically links lzma if you have the compression feature enabled due to the dependency on xz2

Describe the solution you'd like

add a new feature to statically link lzma, or at the very least document the workaround provided below.

Describe alternatives you've considered

You can manually statically link by adding the following to your cargo.toml

lzma-sys = { version = "*", features = ["static"] }

Additional context

some bugs caused by this

@universalmind303 universalmind303 added the enhancement New feature or request label Feb 17, 2024
@guojidan
Copy link
Contributor

Can we add xz2 = { version = "0.1", optional = true, features = ["static"] } into https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/Cargo.toml#L100 ? 😕 cc @alamb

@alamb
Copy link
Contributor

alamb commented Feb 19, 2024

It would certainly be good to add a feature flag (though it might be better to simply always statically link?)

I think statically linking by default makes sense to me and is consistent with most of the rest of the rust ecosystem / crates.

@universalmind303
Copy link
Contributor Author

@alamb i agree. Statically linking by default makes a lot of sense & greatly simplifies things for downstream users. Happy to make this change if you want to assign issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants