Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image tuple support #23

Merged
merged 23 commits into from
Jul 8, 2018
Merged

Add image tuple support #23

merged 23 commits into from
Jul 8, 2018

Conversation

Evizero
Copy link
Owner

@Evizero Evizero commented May 6, 2018

Motivation

The goal of having image tuple support is to support use cases such as image segmentation, where the input and the target are both images.

The interface should be as follows. Where one can currently write:

augment(X, mypipeline)

it should also be possible to write:

augment((X1,X2,X3), mypipeline)

These images should always traverse the same path through the pipeline, even if randomness is involved. As an example if one operation in mypipeline is an elastic distortion, then the distortion must be the same for each of the three images.

Todo list

So far i made some very basic refactors to get the current suite of tests to pass, while allowing for iterative adaption of the individual operations and their tests. Many of the simpler operations should already work, but still lack tests for the new behaviour; those are marked as "missing tests".

General

  • augment
  • augment!
  • augmentbatch!
  • update documentation
  • update README.md maybe some other time
  • update NEWS.md

Operations

  • CacheImage
  • CacheImageInto
  • Either (most complex one)
  • Rotate
  • Scale
  • ShearX
  • ShearY
  • Zoom

Missing Tests

  • SplitChannels
  • CombineChannels
  • PermuteDims
  • Reshape
  • ConvertEltype
  • Crop
  • CropNative
  • CropSize
  • CropRatio
  • RCropRatio
  • ElasticDistortion
  • FlipX
  • FlipY
  • MapFun
  • AggregateThenMapFun
  • NoOp
  • Resize
  • Rotate90
  • Rotate180
  • Rotate270

@Evizero Evizero force-pushed the imagetuple branch 2 times, most recently from 84b0974 to 7a6da4a Compare June 26, 2018 09:15
@Evizero Evizero changed the title WIP: Add image tuple support Add image tuple support Jul 8, 2018
@Evizero Evizero merged commit 6d4f65a into master Jul 8, 2018
@Evizero Evizero deleted the imagetuple branch July 8, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant