Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDC updates #539

Merged
merged 4 commits into from
Dec 2, 2022
Merged

LDC updates #539

merged 4 commits into from
Dec 2, 2022

Conversation

hover2pi
Copy link
Member

Minor updates to the LDC

  • Caches LDC model to speed up multiple calculations on the same spectrum
  • Added NIRISS.GR700XD.2 and NIRISS.GR700XD.3 throughputs to LDC

@pep8speaks
Copy link

pep8speaks commented May 31, 2022 •
edited
Loading

Hello @hover2pi, Thank you for updating !

Line 105:46: W605 invalid escape sequence '\m'
Line 377:31: E261 at least two spaces before inline comment
Line 377:31: E262 inline comment should start with '# '
Line 488:30: W605 invalid escape sequence '\m'
Line 489:32: W605 invalid escape sequence '\m'
Line 489:39: W605 invalid escape sequence '\m'
Line 620:1: W391 blank line at end of file

Comment last updated at 2022-05-31 14:24:46 UTC

@hover2pi hover2pi mentioned this pull request Dec 2, 2022
Merged
@hover2pi hover2pi requested a review from nespinoza December 2, 2022 15:58
@hover2pi hover2pi merged commit a09666d into develop Dec 2, 2022
hover2pi added a commit that referenced this pull request Jul 16, 2024
@hover2pi
Merge pull request #539 from ExoCTK/cache_ldc_model
2eabf2a 
LDC updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nespinoza nespinoza nespinoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hover2pi @pep8speaks @nespinoza @bourque