Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input suffix removed from input type. #2031

Closed
Samjin opened this issue Aug 15, 2024 · 1 comment
Closed

Input suffix removed from input type. #2031

Samjin opened this issue Aug 15, 2024 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@Samjin
Copy link

Samjin commented Aug 15, 2024

Library Version
Any latest version of 6, 7 and upcoming 8.

Describe the bug
#1960

This PR introduces breaking changes for many services, particularly those that use shared type libraries. While a manual fix involving the addition of an Input suffix to a Kotlin class could be a solution, it is important to recognize that this would necessitate updating classes across all services within a large organization, which is not practical.

To Reproduce

@GraphQLValidObjectLocations(locations = [GraphQLValidObjectLocations.Locations.INPUT_OBJECT])
data class UriContext(){}
  1. The above code compiles to UriContextInput graphql type, but now it becomes UriContext.
  2. Another potential problem could arise if there is already a UriContext type.
  3. Subgraph schema generates UriContext after graphql-kotlin updates, but shared type lib with older version of graphql-kotlin could still create UriContextInput.

Expected behavior

Ideally revert the PR. If not possible, can we make it configurable?

@Samjin Samjin added the type: bug Something isn't working label Aug 15, 2024
@samuelAndalon
Copy link
Contributor

#2032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Development

No branches or pull requests

3 participants