feat: ability to specify @GraphQLName on input types w/o suffix
#1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently input types are always suffixed with `Input` which is problematic as there are use cases where users might want to provide different custom name. This change adds check whether specified type is input only and if thats the case it does not attempt to add `Input` suffix.
```kotlin
// old: MyClassInput
// new: MyClass
@GraphQLValidObjectLocations([GraphQLValidObjectLocations.Locations.INPUT_OBJECT])
class MyClass
// can also be combined with renaming
// old: MyRenamedClassInput
// new: MyRenamedClass
@GraphQLValidObjectLocations([GraphQLValidObjectLocations.Locations.INPUT_OBJECT])
@GraphQLName("MyRenamedClass")
class MyClass
```
dariuszkuc
force-pushed
the
graphql_input_name
branch
from
1aa8462
to
ec11992
Compare
dariuszkuc
changed the title
@GraphQLName on input types w/o suffix@GraphQLName on input types w/o suffix
dariuszkuc
added
changes: patch
dariuszkuc
changed the title
@GraphQLName on input types w/o suffix@GraphQLName on input types w/o suffix
|
While technically it is possible that folks used valid location = input + custom name so it could be considered breaking change, this seems rather unlikely case (as they would need to explicitly specify |
|
I am having one question on this. |
clarify that `Input` suffix is only appended IF it already doesn't end with that suffix
samuelAndalon
approved these changes
Apr 17, 2024
samuelAndalon
pushed a commit
that referenced
this pull request
Apr 18, 2024
) ### 📝 Description Currently input types are always suffixed with `Input` which is problematic as there are use cases where users might want to provide different custom name. This change adds check whether specified type is input only and if thats the case it does not attempt to add `Input` suffix. ### 🔗 Related Issues Supersedes #1949
samuelAndalon
pushed a commit
that referenced
this pull request
Apr 18, 2024
) ### 📝 Description Currently input types are always suffixed with `Input` which is problematic as there are use cases where users might want to provide different custom name. This change adds check whether specified type is input only and if thats the case it does not attempt to add `Input` suffix. ### 🔗 Related Issues Supersedes #1949
samuelAndalon
added a commit
that referenced
this pull request
Apr 18, 2024
) (#1962) Co-authored-by: Dariusz Kuc <9501705+dariuszkuc@users.noreply.github.com>
samuelAndalon
added a commit
that referenced
this pull request
Aug 19, 2024
samuelAndalon
added a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Currently input types are always suffixed with
Inputwhich is problematic as there are use cases where users might want to provide different custom name. This change adds check whether specified type is input only and if thats the case it does not attempt to addInputsuffix.🔗 Related Issues
Supersedes #1949