[HOLD for payment 2023-01-25] [$1000] mWeb - Chat - The avatar in the groupDM welcome message does not have the default grey background

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account (applausetester+ihchat3@applause.expensifail.com/ Yulia1986Gerets)
3. Click on FAB button/New Group
4. Choose several users, one of them should have an avatar with a transparent background -> Click "Create group"

Expected Result:

The member with a transparent background PNG avatar in the group's welcome message should have a default grey background, as seen in other places the avatars are displayed.

Actual Result:

The member with a transparent background PNG avatar in the groupDM's welcome message does not have the default grey background

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web

Version Number: 1.2.39.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): applausetester+ihchat3@applause.expensifail.com/ Yulia1986Gerets

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f4e7464efae609c6
• Upwork Job ID: 1612490320358330368
• Last Price Increase: 2023-01-09

[slafortune]

signing out until next week so reassigning this as to not hold it up

[danieldoglas]

assigning this one to me

[stephanieelliott]

Hey @danieldoglas does that mean you'll fix this one internally?

[danieldoglas]

I read it too fast and thought that melvin had added the same person as the one doing triaging for the bug, sorry! I was going to continue it through the normal flow, so please do what you were going to do before, and I'll be here to do the triaging of proposals!

[stephanieelliott]

Hm, I've tested this a few times -- I think this is expected behavior, no? A PNG with a transparent background would show up as it does in the example that was shared:

The alternative would be... backfilling the image background? IMO we should be displaying the image exactly as the user uploaded it.

[danieldoglas]

I think the expected result here would be something like this instead @stephanieelliott

[trjExpensify]

Hm, I agree. I'm not sure I understand how this is a bug. "Not shown correctly" isn't really descriptive, what are we expecting exactly?

CC: @Beamanator

[danieldoglas]

Sorry, I'm not sure if I was not clear, but the image I've uploaded have all users' images on the same size, while the images when using mobile web are different sizes. Is that how they were supposed to be?

[trjExpensify]

It is the same size though, isn't it? It's just the transparent background? I think the question is whether we should be filling the background in, which it looks like we are in other places, but that seems to defeat the purpose of a transparent background:

[danieldoglas]

Ohhhhhhhhhh now I see. When I looked at the first picture in the issue, I thought Beaman's picture was actually two pictures. I'm completely wrong here, sorry about that

[Beamanator]

Lol! Sorry for the confusion y'all :D

[trjExpensify]

@Beamanator, to confirm, are we expecting to fill in the transparent background then? 😕

[Beamanator]

No no I think this isn't an issue so we can close

[Beamanator]

Wait maybe I'm confused?

[melvin-bot]

📣 @bernhardoj You have been assigned to this job by @danieldoglas!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[stephanieelliott]

Sent the offer to @bernhardoj, also extended the job to @eVoloshchak for C+.

[bernhardoj]

PR is ready for review.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.53-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix room header avatar does not have background color #14181

If no regressions arise, payment will be issued on 2023-01-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak / @danieldoglas] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak / @danieldoglas] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak / @danieldoglas] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@stephanieelliott] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[bernhardoj]

There is a regression happened reported here. I have opened a new PR to solve that regression.

@danieldoglas @eVoloshchak

[mountiny]

@stephanieelliott As mentioned above, could we make sure @jayeshmangwani is paid a reporting bonus for reporting the regression https://expensify.slack.com/archives/C049HHMV9SM/p1673730118353969

The reward for the contributor and C+ should be adjusted because of the regression.

Thanks for addressing it so quick @bernhardoj!

[mountiny]

PR Merged!

[eVoloshchak]

Not overdue, PR has been deployed to production 4 days ago

[stephanieelliott]

This has been paid!

[jayeshmangwani]

@stephanieelliott reporting regression bonus is due here

[stephanieelliott]

Oop, sorry I missed that -- sent you the offer in Upwork @jayeshmangwani!

[jayeshmangwani]

Offer accepted @stephanieelliott , Thanks!