[HOLD for Payment 2023-09-20][$2000] Can't parse deep link with email param. #16762

kavimuru · 2023-03-30T17:54:32Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Try to open user detail from deep link on browser (for example: https://staging.new.expensify.com/details?login=testing@gmail.com).
Now go to any report, paste that link and click send.
Notice that it can't parse the whole link, and when user try to click on it, it opens the email app with the wrong email filled.

Expected Result:

App should parse the deep link detail with email param.

Actual Result:

App can't parse the deep link detail with email param. The URL prefix (https://) is not part of the link, and we instead link incorrectly.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.92-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-03-30.at.22.43.51.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680191331185739

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013659e025d6ce0e4f
Upwork Job ID: 1644482548992663552
Last Price Increase: 2023-06-26
Automatic offers:

0xmiroslav | Reviewer | 26524537
Antasel | Contributor | 26524539
hungvu193 | Reporter | 26524541

The text was updated successfully, but these errors were encountered:

MelvinBot · 2023-03-30T17:54:38Z

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot · 2023-03-30T17:54:42Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

sakluger · 2023-04-07T23:29:20Z

I was able to reproduce this issue, feels like a bug worth solving!

MelvinBot · 2023-04-07T23:29:30Z

Job added to Upwork: https://www.upwork.com/jobs/~013659e025d6ce0e4f

MelvinBot · 2023-04-07T23:29:33Z

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

MelvinBot · 2023-04-07T23:29:42Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

MelvinBot · 2023-04-07T23:29:48Z

Triggered auto assignment to @johnmlee101 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

alitoshmatov · 2023-04-07T23:48:22Z

I couldn't reproduce this issue. I am not sure how exactly you are copying the url. Can you provide more details, or elaborate on copying step a little bit more

akinwale · 2023-04-08T00:43:24Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deep links which contain an email address are incorrectly parsed thereby resulting in broken links in the chat history.

What is the root cause of that problem?

The ExpensiMark parser is processing the autoEmail rule before the autoLink rule, which results in a broken link, because the email part of the deep link is parsed first, hence the full link will never be recognised.
The currently defined order is like so: https://github.com/Expensify/expensify-common/blob/main/lib/ExpensiMark.js#L95-L130

What changes do you think we should make in order to solve the problem?

Update the autoEmail rule like so:

{
    name: 'autoEmail',
    regex: new RegExp(
        `(?![^<]*>|[^<>]*<\\/)(^| |(?<!http(s?):\\S*))${CONST.REG_EXP.MARKDOWN_EMAIL}(?![^<]*(<\\/pre>|<\\/code>|<\\/a>))`,
        'gim',
    ),
    replacement: (match, g1, g2, g3) => {
        let repl = `<a href="mailto:${g3}">${g3}</a>`;
        if (match.startsWith(' ')) {
            repl = ' ' + repl;
        }
        return repl;
    }
}

This will make sure that it only matches an email that starts at the beginning of the line, or if there's a space preceding the email, thereby excluding emails that are already in links. The second capture group contains the matching email, so we use that instead of match, which may include a space. The replacement string is conditionally updated to be prefixed with a space based on the match.

This has been tested and works well with the following scenarios:

test@expensify.com https://www.expensify.com
bruh test@expensify.com https://www.expensify.com
https://www.expensify.com test@expensify.com
https://staging.new.expensify.com/details?login= testing@gmail.com bacon antoher@gmail.com
multiple spaces https://www.expensify.com    test@expensify.com
[test ]](test@expensify.com)
another scenario [test@expensify.com]
checking boundaries \test@expensify.com
https://staging.new.expensify.com/details?name=test&email= testing@gmail.com
final@expensify.com last check
testing@gmail.com google.com@gmail.com tests fine
https://www.expensify.com?name=test&email=testing@gmail.com
random@gmail.com https://www.expensify.com?name=test&email=testing@gmail.com random2@gmail.com

Please note that the faulty parsed HTML result (with the broken links) occurs at the composer end, before the data is sent to the API, so previous messages that were already malformed will still remain the same way even after updating the ExpensiMark class implementation. A user would have to edit these messages after the changes have been applied in order to fix the broken links.

What alternative solutions did you explore? (Optional)

None.

hoangzinh · 2023-04-08T06:24:49Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

App can't parse the deep link detail with email param. The URL prefix (https://) is not part of the link, and the rest is in mailto protocol => we link incorrectly.

What is the root cause of that problem?

Context: We're using an internal library to parse a message from text to html in this line

The issue described in GH issue happens only when users send a plain-text url that contain email as a param.
For more details, with a plain-text url string, when it's passed into our parser, it will reach this parser's rule autoEmail. As described in description, this rule tries to "automatically links emails that are not in a link". But it only works with HTML tag but not raw url string.

i.e Given input is https://staging.new.expensify.com/details?login=testing@gmail.com
=> matching text of this rule will be //staging.new.expensify.com/details?login=testing@gmail.com
=> output after this rule is <a href="mailto://staging.new.expensify.com/details?login=testing@gmail.com">//staging.new.expensify.com/details?login=testing@gmail.com</a>
=> it leads to the out of whole parser is https:<a href="mailto://staging.new.expensify.com/details?login=testing@gmail.com">//staging.new.expensify.com/details?login=testing@gmail.com</a>

What changes do you think we should make in order to solve the problem?

To fix this issue, we need to:

Update the regex rule of autoEmail so that it includes optional substring regex ((?:\\S*=)?)
Update replacement of autoEmail rule so that, if the matching string is an URL, we don't need to format to an email link.

Code example

Replace those LOC by

         {
              name: 'autoEmail',
              regex: new RegExp(
                  `(?![^<]*>|[^<>]*<\\/)((?:\\S*=)?)${CONST.REG_EXP.MARKDOWN_EMAIL}(?![^<]*(<\\/pre>|<\\/code>|<\\/a>))`,
                  'gim'
              ),
              replacement: (match, g1, g2) => {
                  const urlRegex = new RegExp(`^${URL_REGEX}$`, 'gi');
                  if (g1 && urlRegex.test(match)) {
                      return match;
                  }

                  return `${g1 || ''}<a href="mailto:${g2}">${g2}</a>`;
              }
          }

tienifr · 2023-04-08T06:45:57Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

App can't parse the deep link detail with email param. The URL prefix (https://) is not part of the link, and we instead link incorrectly.

What is the root cause of that problem?

The root cause is here https://github.com/Expensify/expensify-common/blob/3590b7371fe8fa73288a6625daad985e7fcfb057/lib/ExpensiMark.js#L101 where we're parsing the autoEmail before the autoLink.

So when we're trying to parse https://staging.new.expensify.com/details?login=testing@gmail.com, it will parse //staging.new.expensify.com/details?login=testing@gmail.com as an email. Then when we try to apply the autolink, it will not work because the <a> tags are already inserted by the autoEmail rule.

The ordering of autoEmail and autolink are like that for a reason, to avoid the auto link rule to apply to a part of the email address.

Let's consider this email google.com@gmail.com, if the autolink rule is before the autoEmail rule, the google.com will become an auto link and it will not be parsed as an email.

What changes do you think we should make in order to solve the problem?

We need to do 3 things:

Put the auto link rule before the autoEmail rule, this can be done simply by reodering this rule https://github.com/Expensify/expensify-common/blob/3590b7371fe8fa73288a6625daad985e7fcfb057/lib/ExpensiMark.js#L101 and this rule https://github.com/Expensify/expensify-common/blob/3590b7371fe8fa73288a6625daad985e7fcfb057/lib/ExpensiMark.js#L114
Address this issue.

The ordering of autoEmail and autolink are like that for a reason, to avoid the auto link rule to apply to a part of the email address.

For this, we can modify the URL_WEBSITE_REGEX here https://github.com/Expensify/expensify-common/blob/f37b3bc00d1275f232c7ddb8bbcb5b6f69310918/lib/Url.js#L3 such that it will not match if the domain is followed by an email signature (a.k.a @domain.tld). This can be done by updating this rule https://github.com/Expensify/expensify-common/blob/f37b3bc00d1275f232c7ddb8bbcb5b6f69310918/lib/Url.js#L3
to

const URL_WEBSITE_REGEX = `${URL_PROTOCOL_REGEX}?((?:www\\.)?[a-z0-9](?:[-a-z0-9]*[a-z0-9])?\\.)+(?:${TLD_REGEX})(?!@[a-zA-Z0-9-]+?(\.[a-zA-Z]+)+)(?:\\:${ALLOWED_PORTS}|\\b|(?=_))`;

(note the lookahead (?!@[a-zA-Z0-9-]+?(\.[a-zA-Z]+)+) to match the @domain.tld signature, it's the same regex we're using to match that part of an autoEmail)

Edited: Looks like this has been recently fixed in Expensify/expensify-common#534
There's a hidden bug in here that makes the code abort all instances of matching links if the first match has @. This is because if abort is set to true once, it will persist on the next iteration of the matching links.

In current staging app, we can also easily reproduce it by sending the below

⁦@expensify.com 
https://www.expensify.com

The link https://www.expensify.com will not be detected.

To fix this we need to move the let abort = false; inside the while loop here https://github.com/Expensify/expensify-common/blob/3cdaa947fe77016206c15e523017cd50678f2359/lib/ExpensiMark.js#L372 so it can be reset to false when processing the next match.

What alternative solutions did you explore? (Optional)

We can improve the regex in 2 if there're special edge cases that need to be addressed (special characters, ...), for example by adding

[a-zA-Z0-9.!$%&'*+=^_`{|}~-]

to match the email-compatible part between the matched domain and the @domain.tld signature, but the main point is the same. If an accidental URL that belongs to an email address is not parsed as an auto link, it will be safe to reorder the rules.

FYI the approach to avoid replacing the autoEmail if the matched string is an URL will not work if the matched email string is not the full URL but only a part of the URL (For example an URL with the & character)

ahmedGaber93 · 2023-04-09T01:31:09Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

if we parse link with email param, it parased as email not link.

What is the root cause of that problem?

the REGEXP of autoEmail allow to parse email in link.

What changes do you think we should make in order to solve the problem?

edit REGEXP of autoEmail to be match optional ((?:\\S*[=/])?) and use it in replacement case like this.

{
    name: 'autoEmail',
    regex: new RegExp(
        `(?![^<]*>|[^<>]*<\\/)((?:\\S*[=/])?)${CONST.REG_EXP.MARKDOWN_EMAIL}(?![^<]*(<\\/pre>|<\\/code>|<\\/a>))`,
        'gim',
    ),
    replacement: (match, g1, g2) => {
        // this condition will return true if g1 is link/auto link which mean this email is part of link/auto link.
        // we can also use URL_REGEX and MARKDOWN_URL_REGEX like this
        // if(g1 match URL_REGEX or g1 match MARKDOWN_URL_REGEX) return match;
        if (Str.isValidURL(Str.sanitizeURL(g1))) {
            // if email is part of link or auto link skip parsing.
            return match;
        }
        return g1 + `<a href="mailto:${g2}">${g2}</a>`;
    },
},

Explanation

RegExp will match two groups ((?:\\S*[=/])?) and ${CONST.REG_EXP.MARKDOWN_EMAIL}.
we will use group1 to determined if the matched email (group2) is part of link or not.
2.1 if group1 is found, we need to confirm it is a link and not a normal text like chars "-" or ":"
2.2 we will use Str.isValidURL or URL_REGEX to confirm the group1 is a link.
2.3 in case group1 is auto link, we will use Str.sanitizeURL to convert it to link, then check if it is a link or not Str.isValidURL(Str.sanitizeURL(g1)).
if we confirm group1 is a link or auto link, skip parse auto email return match;
if group1 is not a link, return group1 + parsed email return g1 + `<a href="mailto:${g2}">${g2}</a>`;

all test passed in expensify-common in this comment #16762 (comment)

What alternative solutions did you explore? (Optional)

N/A

anaskhraza · 2023-04-09T10:49:38Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

App can't parse the deep link detail with email param. The URL prefix (https://) is not part of the link, and we instead link incorrectly.

What is the root cause of that problem?

1 - When the user tries to send a deeplink with email as param, the parser rule that we have defined in the library rule autoEmail should automatically links the email. However our current rule can only work with HTML tags not the raw URL string.

2 - The placement of autoemail rule is also contributing to the problem, as it's been placed before autolink.

What changes do you think we should make in order to solve the problem?

Step 1 - Update the regex rule to prevent match emails if string contains http or https

Step 2 - Reorder autoEmail rule to check if the matching string is a URL, we will use URL_REGEX and don't need to format to an email link

What alternative solutions did you explore? (Optional)

none

MelvinBot · 2023-04-09T10:49:42Z

📣 @anaskhraza! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

0xmiros · 2023-09-06T12:06:53Z

@Antasel let's make sure to add all automated test cases if possible.
Combine all of these:
#16762 (comment)
#16762 (comment)
#16762 (comment)
And more whatever you find is edge case including yours - #16762 (comment)

Antasel · 2023-09-06T12:38:22Z

@0xmiroslav The following test cases are covering all of what you mentioned

Test Cases

test('Test a url with email autolinks correctly', () => {
    let testString = 'https://staging.new.expensify.com/details?login=testing@gmail.com';
    let resultString = '<a href="https://staging.new.expensify.com/details?login=testing@gmail.com" target="_blank" rel="noreferrer noopener">https://staging.new.expensify.com/details?login=testing@gmail.com</a>';
    testString = 'test@expensify.com/https://www.expensify.com';
    resultString = '<a href="mailto:test@expensify.com">test@expensify.com</a>/<a href="https://www.expensify.com" target="_blank" rel="noreferrer noopener">https://www.expensify.com</a>';
    expect(parser.replace(testString)).toBe(resultString);
});
test('Test a url autolinks correctly', () => {
    let testString = 'test@expensify.com https://www.expensify.com\n' +
    'test@expensify.com-https://www.expensify.com\n' +
    'test@expensify.com/https://www.expensify.com\n' +
    'test@expensify.com?https://www.expensify.com\n' +
    'test@expensify.com>https://www.expensify.com\n' +
    'https://staging.new.expensify.com/details/test@expensify.com\n' +
    'staging.new.expensify.com/details\n\n' +
    'https://www.expensify.com?name=test&email=test@expensify.com\n' +
    'https://staging.new.expensify.com/details?login=testing@gmail.com\n' +
    'staging.new.expensify.com/details?login=testing@gmail.com\n' +
    'http://necolas.github.io/react-native-web/docs/?path=/docs/components-pressable--disabled\n' +
    '-https://www.expensify.com /https://www.expensify.com @https://www.expensify.com\n' +
    'expensify.com -expensify.com @expensify.com\n' +
    'https//www.expensify.com\n' +
    '//www.expensify.com?name=test&email=test@expensify.com\n' +
    '//staging.new.expensify.com/details?login=testing@gmail.com\n' +
    '/details?login=testing@gmail.com\n' +
    '?name=test&email=test@expensify.com\n\n' +
    'example.com/https://www.expensify.com\n' +
    'test@gmail.com staging.new.expensify.com/details?login=testing@gmail.com&redirectUrl=https://google.com\n' +
    'test@gmail.com //staging.new.expensify.com/details?login=testing@gmail.com&redirectUrl=https://google.com\n' +
    'test@gmail.com-https://staging.new.expensify.com/details?login=testing@gmail.com&redirectUrl=https://google.com';
    let resultString = '<a href="mailto:test@expensify.com">test@expensify.com</a> <a href="https://www.expensify.com" target="_blank" rel="noreferrer noopener">https://www.expensify.com</a><br />' + 
    '<a href="mailto:test@expensify.com">test@expensify.com</a>-<a href="https://www.expensify.com" target="_blank" rel="noreferrer noopener">https://www.expensify.com</a><br />' +
    '<a href="mailto:test@expensify.com">test@expensify.com</a>/<a href="https://www.expensify.com" target="_blank" rel="noreferrer noopener">https://www.expensify.com</a><br />' +
    '<a href="mailto:test@expensify.com">test@expensify.com</a>?<a href="https://www.expensify.com" target="_blank" rel="noreferrer noopener">https://www.expensify.com</a><br />' + 
    '<a href="mailto:test@expensify.com">test@expensify.com</a>&gt;<a href="https://www.expensify.com" target="_blank" rel="noreferrer noopener">https://www.expensify.com</a><br />' +
    '<a href="https://staging.new.expensify.com/details/test@expensify.com" target="_blank" rel="noreferrer noopener">https://staging.new.expensify.com/details/test@expensify.com</a><br />' +
    '<a href="https://staging.new.expensify.com/details" target="_blank" rel="noreferrer noopener">staging.new.expensify.com/details</a><br /><br />'+ 
    '<a href="https://www.expensify.com?name=test&amp;email=test@expensify.com" target="_blank" rel="noreferrer noopener">https://www.expensify.com?name=test&amp;email=test@expensify.com</a><br />' +
    '<a href="https://staging.new.expensify.com/details?login=testing@gmail.com" target="_blank" rel="noreferrer noopener">https://staging.new.expensify.com/details?login=testing@gmail.com</a><br />' +
    '<a href="https://staging.new.expensify.com/details?login=testing@gmail.com" target="_blank" rel="noreferrer noopener">staging.new.expensify.com/details?login=testing@gmail.com</a><br />' +
    '<a href="http://necolas.github.io/react-native-web/docs/?path=/docs/components-pressable--disabled" target="_blank" rel="noreferrer noopener">http://necolas.github.io/react-native-web/docs/?path=/docs/components-pressable--disabled</a><br />' +
    '-<a href="https://www.expensify.com" target="_blank" rel="noreferrer noopener">https://www.expensify.com</a> /<a href="https://www.expensify.com" target="_blank" rel="noreferrer noopener">https://www.expensify.com</a> @https://www.expensify.com<br />' +
    '<a href="https://expensify.com" target="_blank" rel="noreferrer noopener">expensify.com</a> -<a href="https://expensify.com" target="_blank" rel="noreferrer noopener">expensify.com</a> @expensify.com<br />' +
    'https//<a href="https://www.expensify.com" target="_blank" rel="noreferrer noopener">www.expensify.com</a><br />' +
    '//<a href="https://www.expensify.com?name=test&amp;email=test@expensify.com" target="_blank" rel="noreferrer noopener">www.expensify.com?name=test&amp;email=test@expensify.com</a><br />' +
    '//<a href="https://staging.new.expensify.com/details?login=testing@gmail.com" target="_blank" rel="noreferrer noopener">staging.new.expensify.com/details?login=testing@gmail.com</a><br />' +
    '/details?login=<a href="mailto:testing@gmail.com">testing@gmail.com</a><br />' +
    '?name=test&amp;email=<a href="mailto:test@expensify.com">test@expensify.com</a><br /><br />' +
    '<a href="https://example.com/https://www.expensify.com" target="_blank" rel="noreferrer noopener">example.com/https://www.expensify.com</a><br />' +
    '<a href="mailto:test@gmail.com">test@gmail.com</a> <a href="https://staging.new.expensify.com/details?login=testing@gmail.com&amp;redirectUrl=https://google.com" target="_blank" rel="noreferrer noopener">staging.new.expensify.com/details?login=testing@gmail.com&amp;redirectUrl=https://google.com</a><br />' +
    '<a href="mailto:test@gmail.com">test@gmail.com</a> //<a href="https://staging.new.expensify.com/details?login=testing@gmail.com&amp;redirectUrl=https://google.com" target="_blank" rel="noreferrer noopener">staging.new.expensify.com/details?login=testing@gmail.com&amp;redirectUrl=https://google.com</a><br />' +
    '<a href="mailto:test@gmail.com">test@gmail.com</a>-<a href="https://staging.new.expensify.com/details?login=testing@gmail.com&amp;redirectUrl=https://google.com" target="_blank" rel="noreferrer noopener">https://staging.new.expensify.com/details?login=testing@gmail.com&amp;redirectUrl=https://google.com</a>';
    expect(parser.replace(testString)).toBe(resultString);

    testString = 'test@gmail.com/https://example.com/google@email.com?email=asd@email.com';
    resultString = '<a href="mailto:test@gmail.com\">test@gmail.com</a>/<a href="https://example.com/google@email.com?email=asd@email.com" target="_blank" rel="noreferrer noopener">https://example.com/google@email.com?email=asd@email.com</a>';
    expect(parser.replace(testString)).toBe(resultString);

    testString = 'test@gmail.com/test@gmail.com/https://example.com/google@email.com?email=asd@email.com';
    resultString = '<a href="mailto:test@gmail.com">test@gmail.com</a>/<a href="mailto:test@gmail.com">test@gmail.com</a>/<a href="https://example.com/google@email.com?email=asd@email.com" target="_blank" rel="noreferrer noopener">https://example.com/google@email.com?email=asd@email.com</a>';
    expect(parser.replace(testString)).toBe(resultString);
});

Antasel · 2023-09-06T15:13:22Z

@0xmiroslav @sakluger
The PR Expensify/expensify-common#573 for expensify-common is ready for review

Antasel · 2023-09-11T04:27:06Z

@johnmlee101
Could you help me to get expensify open-source channel invitation on Slack ?
I've sent email to contributors@expensify.com, but still no on my anayetrasel@yahoo.com .

0xmiros · 2023-09-11T04:44:55Z

Expensify/expensify-common#573 was merged but based on https://expensify.slack.com/archives/C02NK2DQWUX/p1694406422306609, we can wait a bit more for app PR (just version bump) to be merged until next deploy.

johnmlee101 · 2023-09-11T04:50:11Z

@Antasel you'll have to wait for the approval. We typically wait for you to be in these channels before we allow for fully processing payments as a requirement. Note this will not affect any of the payments themselves

Antasel · 2023-09-11T07:53:32Z

@johnmlee101
I am not worrying about payment, just would like to live in expensify community and get instant help from other devs if needed.
I am getting some new issues on building android/ios

sakluger · 2023-09-11T16:09:27Z

@Antasel got it, thanks for the context. We still need to wait for a slack admin to approve the invite, it's usually done within a day or so.

johnmlee101 · 2023-09-12T02:17:08Z

Hi, it should have been approved. Please check your email!

Antasel · 2023-09-12T03:25:00Z

Hi, it should have been approved. Please check your email!

I sent email again to contributors@expensify.com yesterday. but still no updated. waiting more

0xmiros · 2023-09-12T05:12:17Z

expensify-common package version was bumped to the latest in #27169 and our fix was already deployed to staging.
So all good now.

Antasel · 2023-09-12T06:57:26Z

@0xmiroslav then no need to make App PR ?

0xmiros · 2023-09-12T09:58:01Z

@0xmiroslav then no need to make App PR ?

Correct. You can test staging app right now

Antasel · 2023-09-12T10:56:34Z

@0xmiroslav Is there any guide to run staging app for desktop, android, iOS ?

0xmiros · 2023-09-12T10:58:36Z

@0xmiroslav Is there any guide to run staging app for desktop, android, iOS ?

iOS staging app is on Testflight https://testflight.apple.com/join/ucuXr4g5

Antasel · 2023-09-12T11:09:26Z

thanks.
Where can i download desktop app image ? and for android ?

0xmiros · 2023-09-12T11:11:14Z

thanks. Where can i download desktop app image ? and for android ?

I also don't know. Your questions are out of scope for this GH.
You can just verify staging web as this issue doesn't depend on platforms.

Antasel · 2023-09-12T11:29:39Z

Ok. I've tested on staging web. working as expected.

Screencast.from.12-9-23.05.25.49+06.webm

sakluger · 2023-09-14T16:36:30Z

The PR isn't showing that it was deployed to staging or prod, @0xmiroslav is that specific to Expensfy/expensify-common? I want to make sure the payment date is reflected correctly.

0xmiros · 2023-09-14T16:40:12Z

The PR isn't showing that it was deployed to staging or prod, @0xmiroslav is that specific to Expensfy/expensify-common? I want to make sure the payment date is reflected correctly.

Correct, in general there should be app PR linked to this issue which just bumps expensify-common version.
But this is edge case. Version was bumped in other PR which fixes another issue.

In our case, we can update issue title manually.
Deployed to production on Sep 13 - #27169 (comment)

0xmiros · 2023-09-14T16:42:45Z

thanks. Where can i download desktop app image ? and for android ?

@Antasel Here's the answer:
desktop: https://staging.new.expensify.com/NewExpensify.dmg
android: I believe there you would have to be accepted on some internal list so its not very scalable

Antasel · 2023-09-18T03:18:15Z

@0xmiroslav thanks for your kind answer

sakluger · 2023-09-18T08:03:22Z

@0xmiroslav thanks!

Copying over the BZ checklist manually since the automation didn't post it in this case:

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
[@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@0xmiroslav] Determine if we should create a regression test for this bug.
[@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

sakluger · 2023-09-20T06:25:24Z

So excited to close out this issue, thanks everyone!

Summarizing payouts for this issue:

Issue reporter: @hungvu193 $250 (hired and paid via Upwork)
Contributor: @Antasel $3000 (hired and paid via Upwork)
Contributor+: @0xmiroslav $3000

Above payments include efficiency bonus 🎉
Upwork job: https://www.upwork.com/jobs/~013659e025d6ce0e4f

@0xmiroslav - two things:

Could you please complete the BZ checklist?
Would you like to be paid via NewDot manual request or via Upwork? I see that we sent you an offer here, but it's probably because this issue is so old.

0xmiros · 2023-09-20T06:27:59Z

No regressions. We added lots of automated test cases so I think that should cover regression test enough.

0xmiros · 2023-09-20T06:34:55Z

Would you like to be paid via NewDot manual request or via Upwork?

upwork

sakluger · 2023-09-20T09:31:13Z

Thanks! I completed the payment through Upwork.

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 30, 2023

melvin-bot bot assigned sakluger Mar 30, 2023

melvin-bot bot added the Overdue label Apr 3, 2023

This comment was marked as outdated.

Sign in to view

sakluger mentioned this issue Apr 7, 2023

Text message highlights the invalid email address. #17105

Closed

6 tasks

melvin-bot bot removed the Overdue label Apr 7, 2023

sakluger added External Added to denote the issue can be worked on by a contributor Overdue labels Apr 7, 2023

melvin-bot bot changed the title ~~Can't parse deep link with email param.~~ [$1000] Can't parse deep link with email param. Apr 7, 2023

melvin-bot bot assigned 0xmiros Apr 7, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 7, 2023

melvin-bot bot assigned johnmlee101 Apr 7, 2023

sakluger removed the Overdue label Apr 7, 2023

Antasel mentioned this issue Sep 6, 2023

fix: parse deep link correctly Expensify/expensify-common#573

Merged

sakluger changed the title ~~[$2000] Can't parse deep link with email param.~~ [HOLD for Payment 2023-09-20][$2000] Can't parse deep link with email param. Sep 18, 2023

sakluger closed this as completed Sep 20, 2023

[HOLD for Payment 2023-09-20][$2000] Can't parse deep link with email param. #16762

[HOLD for Payment 2023-09-20][$2000] Can't parse deep link with email param. #16762

Comments

kavimuru commented Mar 30, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

MelvinBot commented Mar 30, 2023

MelvinBot commented Mar 30, 2023 • edited by sakluger Loading

Bug0 Triage Checklist (Main S/O)

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

sakluger commented Apr 7, 2023

MelvinBot commented Apr 7, 2023

MelvinBot commented Apr 7, 2023

MelvinBot commented Apr 7, 2023

MelvinBot commented Apr 7, 2023

alitoshmatov commented Apr 7, 2023

akinwale commented Apr 8, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

hoangzinh commented Apr 8, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

tienifr commented Apr 8, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ahmedGaber93 commented Apr 9, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Explanation

What alternative solutions did you explore? (Optional)

anaskhraza commented Apr 9, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

MelvinBot commented Apr 9, 2023

0xmiros commented Sep 6, 2023 • edited Loading

Antasel commented Sep 6, 2023

Antasel commented Sep 6, 2023

Antasel commented Sep 11, 2023

0xmiros commented Sep 11, 2023

johnmlee101 commented Sep 11, 2023

Antasel commented Sep 11, 2023

sakluger commented Sep 11, 2023

johnmlee101 commented Sep 12, 2023

Antasel commented Sep 12, 2023

0xmiros commented Sep 12, 2023

Antasel commented Sep 12, 2023

0xmiros commented Sep 12, 2023

Antasel commented Sep 12, 2023

0xmiros commented Sep 12, 2023

Antasel commented Sep 12, 2023

0xmiros commented Sep 12, 2023

Antasel commented Sep 12, 2023

sakluger commented Sep 14, 2023

0xmiros commented Sep 14, 2023

0xmiros commented Sep 14, 2023 • edited Loading

Antasel commented Sep 18, 2023

sakluger commented Sep 18, 2023

sakluger commented Sep 20, 2023

0xmiros commented Sep 20, 2023

0xmiros commented Sep 20, 2023

sakluger commented Sep 20, 2023

kavimuru commented Mar 30, 2023 •

edited by melvin-bot bot

Loading

MelvinBot commented Mar 30, 2023 •

edited by sakluger

Loading

akinwale commented Apr 8, 2023 •

edited

Loading

hoangzinh commented Apr 8, 2023 •

edited

Loading

tienifr commented Apr 8, 2023 •

edited

Loading

ahmedGaber93 commented Apr 9, 2023 •

edited

Loading

0xmiros commented Sep 6, 2023 •

edited

Loading

0xmiros commented Sep 14, 2023 •

edited

Loading