Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto link after email domain not parsed. #534

Merged
merged 1 commit into from
May 11, 2023
Merged

fix: auto link after email domain not parsed. #534

merged 1 commit into from
May 11, 2023

Conversation

ahmedGaber93
Copy link
Contributor

@ahmedGaber93 ahmedGaber93 commented May 11, 2023 •
edited by francoisl
Loading

@parasharrajat @francoisl

Fixed Issues

Needed for Expensify/App#18443

Tests

  1. Go to any chat and add a comment
@google.com google.com
  1. Verify that the @google.com is displayed as plain text and the next google.com is displayed as a link.

QA

Same as test

@ahmedGaber93 ahmedGaber93 requested a review from a team as a code owner May 11, 2023 20:37
@github-actions
Copy link

github-actions bot commented May 11, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from hayata-suenaga and removed request for a team May 11, 2023 20:38
@ahmedGaber93 ahmedGaber93 reopened this May 11, 2023
@ahmedGaber93
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ahmedGaber93 ahmedGaber93 mentioned this pull request May 11, 2023
Closed
6 tasks
parasharrajat
parasharrajat approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested a couple of combinations manually.

cc: @hayata-suenaga @francoisl

francoisl
francoisl approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@francoisl francoisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francoisl francoisl merged commit 5f4672c into Expensify:main May 11, 2023
@melvin-bot melvin-bot bot added the Emergency Marks a change in which we bypassed our normal process (eg, skipped travis) label May 11, 2023
@melvin-bot

This comment was marked as resolved.

Sign in to view
@francoisl
Copy link
Contributor

francoisl commented May 11, 2023 •
edited
Loading

We'll also need to update expensify-common to the latest version in the App repo. Feel free to send a PR for that, otherwise I can do it later.

looks like this was merged without a test passing

I think this is a melvin-bot bug, the checks were passing (I had to manually restart the CLA check first)

@francoisl francoisl removed the Emergency Marks a change in which we bypassed our normal process (eg, skipped travis) label May 11, 2023
@tienifr tienifr mentioned this pull request May 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisl francoisl francoisl approved these changes

@parasharrajat parasharrajat parasharrajat approved these changes

@hayata-suenaga hayata-suenaga Awaiting requested review from hayata-suenaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedGaber93 @francoisl @parasharrajat