-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: auto link after email domain not parsed. #534
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested a couple of combinations manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This comment was marked as resolved.
This comment was marked as resolved.
We'll also need to update
I think this is a melvin-bot bug, the checks were passing (I had to manually restart the CLA check first) |
@parasharrajat @francoisl
Fixed Issues
Needed for Expensify/App#18443
Tests
@google.com
is displayed as plain text and the nextgoogle.com
is displayed as a link.QA
Same as test