[HOLD for payment 2023-07-26] [$1000] App keeps the hover state when returning back from the opened links

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app in mac chrome/mac safari
2. Open settings
3. Click on help link
4. Revisit the expensify tab and observe that link still has background hover color

Expected Result:

App should remove the hover effect from link background when clicked (when visiting external link) - like it does on Windows Chrome

Actual Result:

App keeps the hover effect on external link even when we click and visit the link

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.12.0
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

hover.stuck.external.link.mac.mov

Recording.187.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683626608112949

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016746e1721b3e89aa
• Upwork Job ID: 1656133072671420416
• Last Price Increase: 2023-06-01

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jliexpensify]

Yep, can repro this one!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016746e1721b3e89aa

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Triggered auto assignment to @jasperhuangg (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jliexpensify]

@jasperhuangg @aimane-chnaif - curious to get your thoughts: will @allroundexperts proposal in #16923 resolve this issue as well?

[mostfa29]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The problem we are trying to solve in this issue is that the App's hover effect on a link's background is not being removed when the link is clicked and visited externally.

What is the root cause of that problem?

The root cause of the problem is that when a user clicks on an external link, the focus is shifted away from the component, but the onBlur event is not triggered. As a result, the onPressOut event is not triggered either.

What changes do you think we should make in order to solve the problem?

In order to solve the problem, we can add an event listener to the external link and manually trigger the onBlur event for the component when the external link is clicked. This will ensure that the onPressOut event is triggered even when the focus is shifted away from the component.

What alternative solutions did you explore? (Optional)

I explored several alternative solutions, including using the onFocus event instead of onBlur, and using a different event handler for external links. However, I found that manually triggering the onBlur event was the most effective solution.

[melvin-bot]

📣 @mostfa29! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[mostfa29]

Contributor details
Your Expensify account email: amin29199@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~011bc7e925bdaf6efe

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[jasperhuangg]

@jliexpensify Yup, looks like that proposal will solve this issue as well in one-fell swoop. Let's HOLD this issue on that one

[jasperhuangg]

still on HOLD

[allroundexperts]

@jasperhuangg My proposal wasn't able to go through. You can read more about this here and also add your opinion.

[jasperhuangg]

@allroundexperts If your proposal isn't able to fix all instances of this issue in one-fell swoop, then I think this particular instance of the issue isn't worth fixing, since when the user navigates back to the page the issue disappears.

[jliexpensify]

Hmm @aimane-chnaif it says the Upworks job is closed. Did you get an actual invite?

[aimane-chnaif]

No invitation

[jliexpensify]

Weird ok, I guess the following is happening:

1. Upworks jobs longer than 1 month are being auto-closed (?)
2. When an Engineer assigns a contributor, since the job is closed, they don't get the invite

I'll create a manual job, this is pretty annoying!

[jliexpensify]

https://www.upwork.com/jobs/~01ae392bba5fe121b4

Invites sent!

[dhanashree-sawant]

@jliexpensify, Thanks! Offer accepted.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @cubuspl42 got assigned: 2023-07-11 18:59:22 Z
• when the PR got merged: 2023-07-14 22:20:49 UTC
• days elapsed: 3

On to the next one 🚀

[cubuspl42]

@MelvinBot Well, you're technically right, but it nearly made it, the PR was submitted 4 hours after the assignment and the review comments were minor. What took the time was waiting for review. But you're a good bot anyway.

[jliexpensify]

Yeah, that's fine - we'll pay put a bonus since you just missed out on the timeframe @cubuspl42 . Btw, you invoice us separately, correct?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[aimane-chnaif]

Not a blocker - #23052 (comment)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix MenuItem hover state when external links are followed #22702

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

@aimane-chnaif bump to please complete the checklist

Looks like this qualifies for a bonus

@cubuspl42 - just confirming, do you invoice us separately?

[aimane-chnaif]

I don't think we need regression test. The issue itself is edge case.

[cubuspl42]

@jliexpensify I'm sorry but I don't understand the question 🙁 Is it related to something on Upwork?

[jliexpensify]

Yes @cubuspl42 - I'm just wondering if you're from an external agency and invoicing us separately, or if you've got an Upworks profile? :)

[cubuspl42]

@jliexpensify Via Upwork: https://www.upwork.com/freelancers/jakubt

[jliexpensify]

Great, thanks - I'll pay out in a couple of days: https://www.upwork.com/jobs/~01ae392bba5fe121b4

Jakub - $1000 + $500 (bonus)
Aimane - $1000 (C+) + $500 (bonus)
Dhanashree - $250 (reporting)

[jliexpensify]

Everyone is paid and job is closed!