-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-07-26] [$1000] App keeps the hover state when returning back from the opened links #18675
Comments
Triggered auto assignment to @jliexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Yep, can repro this one! |
Job added to Upwork: https://www.upwork.com/jobs/~016746e1721b3e89aa |
Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif ( |
Triggered auto assignment to @jasperhuangg ( |
@jasperhuangg @aimane-chnaif - curious to get your thoughts: will @allroundexperts proposal in #16923 resolve this issue as well? |
ProposalPlease re-state the problem that we are trying to solve in this issue.The problem we are trying to solve in this issue is that the App's hover effect on a link's background is not being removed when the link is clicked and visited externally. What is the root cause of that problem?The root cause of the problem is that when a user clicks on an external link, the focus is shifted away from the component, but the onBlur event is not triggered. As a result, the onPressOut event is not triggered either. What changes do you think we should make in order to solve the problem?In order to solve the problem, we can add an event listener to the external link and manually trigger the onBlur event for the component when the external link is clicked. This will ensure that the onPressOut event is triggered even when the focus is shifted away from the component. What alternative solutions did you explore? (Optional)I explored several alternative solutions, including using the onFocus event instead of onBlur, and using a different event handler for external links. However, I found that manually triggering the onBlur event was the most effective solution. |
📣 @mostfa29! 📣
|
|
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@jliexpensify Yup, looks like that proposal will solve this issue as well in one-fell swoop. Let's HOLD this issue on that one |
still on HOLD |
@jasperhuangg My proposal wasn't able to go through. You can read more about this here and also add your opinion. |
@allroundexperts If your proposal isn't able to fix all instances of this issue in one-fell swoop, then I think this particular instance of the issue isn't worth fixing, since when the user navigates back to the page the issue disappears. |
Hmm @aimane-chnaif it says the Upworks job is closed. Did you get an actual invite? |
No invitation |
Weird ok, I guess the following is happening:
I'll create a manual job, this is pretty annoying! |
https://www.upwork.com/jobs/~01ae392bba5fe121b4 Invites sent! |
@jliexpensify, Thanks! Offer accepted. |
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀 |
@MelvinBot Well, you're technically right, but it nearly made it, the PR was submitted 4 hours after the assignment and the review comments were minor. What took the time was waiting for review. But you're a good bot anyway. |
Yeah, that's fine - we'll pay put a bonus since you just missed out on the timeframe @cubuspl42 . Btw, you invoice us separately, correct? |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Not a blocker - #23052 (comment) |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-07-26. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@aimane-chnaif bump to please complete the checklist Looks like this qualifies for a bonus @cubuspl42 - just confirming, do you invoice us separately? |
I don't think we need regression test. The issue itself is edge case. |
@jliexpensify I'm sorry but I don't understand the question 🙁 Is it related to something on Upwork? |
Yes @cubuspl42 - I'm just wondering if you're from an external agency and invoicing us separately, or if you've got an Upworks profile? :) |
Great, thanks - I'll pay out in a couple of days: https://www.upwork.com/jobs/~01ae392bba5fe121b4 Jakub - $1000 + $500 (bonus) |
Everyone is paid and job is closed! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
App should remove the hover effect from link background when clicked (when visiting external link) - like it does on Windows Chrome
Actual Result:
App keeps the hover effect on external link even when we click and visit the link
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.12.0
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
hover.stuck.external.link.mac.mov
Recording.187.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683626608112949
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: