Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-14] Clicking back from one of the settings option doesn't return user to 'Settings' section #20620

Closed
1 of 6 tasks
kavimuru opened this issue Jun 12, 2023 · 32 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@kavimuru
Copy link

kavimuru commented Jun 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on 'Profile' avatar
  2. Click on 'Security' link
  3. Click on back icon on the top left section of the RHN
  4. Click on 'About' link
  5. Click on the device's back icon on bottom right section

Expected Result:

App should navigate to Settings section

Actual Result:

App navigates back to Security section

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.26-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230607_134506_Chrome.mp4
az_recorder_20230612_163133.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686135238712669

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0189586de561f422cc
  • Upwork Job ID: 1668380084272345088
  • Last Price Increase: 2023-06-12
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny mountiny self-assigned this Jun 12, 2023
@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0189586de561f422cc

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

@mountiny
Copy link
Contributor

This one should be handled by SWM

@mountiny mountiny moved this from Todo to In Progress in Navigation Refactor Follow-ups Jun 12, 2023
@mountiny mountiny moved this from In Progress to Higher Priority in Navigation Refactor Follow-ups Jun 12, 2023
@mountiny
Copy link
Contributor

its on the list

@melvin-bot melvin-bot bot added the Overdue label Jun 16, 2023
@mountiny
Copy link
Contributor

@adamgrzybowski is going to have a look at this one.

@melvin-bot melvin-bot bot removed the Overdue label Jun 19, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jun 19, 2023
@mountiny mountiny moved this from Higher Priority to In Progress in Navigation Refactor Follow-ups Jun 19, 2023
@mountiny
Copy link
Contributor

PR is up in review

@mountiny
Copy link
Contributor

@abdulrahuman5196 has been assigned to the PR review since they are on another issue the PR solves. @parasharrajat is it fine if I assign them here too?

@parasharrajat
Copy link
Member

Sure @mountiny

@melvin-bot
Copy link

melvin-bot bot commented Jun 27, 2023

@anmurali, @mountiny, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@abdulrahuman5196
Copy link
Contributor

PR is in review state.

@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@abdulrahuman5196
Copy link
Contributor

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This issue was caused after the navigation refractor and fixed as part navigation refractor followups. So we can't point a single PR for this issue.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

  1. Click on 'Profile' avatar
  2. Click on 'Security' link
  3. Click on back icon on the top left section of the RHN
  4. Click on 'About' link
  5. Click on the device's back icon on bottom right section
  6. You should be on the settings root screen

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2023
@abdulrahuman5196
Copy link
Contributor

@anmurali BZ checklist is complete here #20620 (comment) now.

Payment processing for this issue should be unblocked now

@mountiny
Copy link
Contributor

I think we could add this regression test.

@melvin-bot melvin-bot bot added the Overdue label Jul 19, 2023
@anmurali
Copy link

I believe @adamgrzybowski is Software Mansion and so is paid by invoice.
@abdulrahuman5196 - here is your offer (https://www.upwork.com/nx/wm/offer/25638711)

@melvin-bot melvin-bot bot removed the Overdue label Jul 19, 2023
@Natnael-Guchima
Copy link

@anmurali can you please send me an offer for reporting bonus? I have reported this issue.

@mountiny mountiny moved this from In Progress to Done in Navigation Refactor Follow-ups Jul 20, 2023
@abdulrahuman5196
Copy link
Contributor

I believe is Software Mansion and so is paid by invoice. @abdulrahuman5196 - here is your offer (https://www.upwork.com/nx/wm/offer/25638711)

@anmurali Accepted this offer sometime back. Missed to ping here.

@anmurali
Copy link

Paid @abdulrahuman5196
Offer sent here for @Natnael-Guchima

@Natnael-Guchima
Copy link

Accepted the offer. Thanks @anmurali

@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 26, 2023
@mountiny mountiny added Overdue Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor

@isabelastisser could you please finish this one up for Anu who is ooo, thanks!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 26, 2023
@isabelastisser
Copy link
Contributor

Not overdue, I was OOO. I will prioritize this tomorrow.

@melvin-bot melvin-bot bot removed the Overdue label Jul 31, 2023
@isabelastisser
Copy link
Contributor

Payment summary:

@abdulrahuman5196 C+ review, paid $1000
@Natnael-Guchimar reported the issue, paid $250

@isabelastisser
Copy link
Contributor

Issue for TestRail.

We should be all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Development

No branches or pull requests

7 participants